linux-kernel - Re: Of fsl_mc_allocator_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZzdcGbIRCjOqaVbS@gallifrey>
Date: Fri, 15 Nov 2024 14:35:05 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Ioana Ciornei <ioana.ciornei@....com>
Cc: stuyoder@...il.com, linux-kernel@...r.kernel.org
Subject: Re: Of fsl_mc_allocator_driver_exit

* Ioana Ciornei (ioana.ciornei@....com) wrote:
> On Fri, Nov 15, 2024 at 02:26:19PM +0000, Dr. David Alan Gilbert wrote:
> > * Ioana Ciornei (ioana.ciornei@....com) wrote:
> > > > * Dr. David Alan Gilbert (linux@...blig.org) wrote:
> > > > > Hi,
> > > > >   One of my scripts noticed that fsl_mc_allocator_driver_exit()
> > > > > was added explicitly in
> > > > > commit 1e8ac83b6caf ("bus: fsl-mc: add fsl_mc_allocator cleanup function")
> > > > >
> > > > > but appears to be unused; given it's a cleanup function it feels like
> > > > > it should be wired up _somewhere_.
> > > > >
> > >
> > > I don't think that fsl_mc_allocator_driver_exit() is of any use at this
> > > point. The entire FSL_MC_BUS can only be built-in which means that there
> > > is no module_exit() which references it.
> >
> > OK, well I'm happy to send a patch to clean it out, I was also
> > going to clean out fsl_mc_portal_reset().
> 
> Sure. Please keep me in cc so that I can give it a run.

No problem.

> >
> > > The same thing is true about the dprc_driver_exit() function.
> >
> > Hmm, that's explicitly called from the error path of fsl_mc_bus_driver_init
> 
> My bad. I missed that.

OK,

Dave

> Thanks,
> Ioana
> 
> 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/