linux-kernel - Re: [PATCH] virtio-fs: Query rootmode during mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAJfpegtQhcGNaH8k1XKTSV_9=T4Ayx8oDLUK-0X8CRg6Rhb1vg@mail.gmail.com>
Date: Fri, 15 Nov 2024 16:24:47 +0100
From: Miklos Szeredi <miklos@...redi.hu>
To: Hanna Czenczek <hreitz@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
	virtualization@...ts.linux.dev, Miklos Szeredi <mszeredi@...hat.com>, 
	German Maglione <gmaglione@...hat.com>, Stefan Hajnoczi <stefanha@...hat.com>, 
	Eugenio Pérez <eperezma@...hat.com>, 
	Vivek Goyal <vgoyal@...hat.com>
Subject: Re: [PATCH] virtio-fs: Query rootmode during mount

On Fri, 15 Nov 2024 at 15:51, Hanna Czenczek <hreitz@...hat.com> wrote:

> Now that I look at it once again (because I was wondering why to check fm, and not fm->fc), do we even need to check fm or fm->fc?  fuse_mount_destroy() assumes both are non-NULL, so I assume sb->s_root || fm->fc->initialized should be OK, too…

You're right, fm can't be NULL.  Not sure why I thought it can.

Thanks,
Miklos