linux-kernel - Re: [PATCH] drm: rework FB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <96269b2e-2a0e-4c7e-9d47-a52e64d1ea0a@app.fastmail.com>
Date: Fri, 15 Nov 2024 17:35:46 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Thomas Zimmermann" <tzimmermann@...e.de>,
 "Arnd Bergmann" <arnd@...nel.org>
Cc: "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
 "Maxime Ripard" <mripard@...nel.org>, "Dave Airlie" <airlied@...il.com>,
 "Simona Vetter" <simona@...ll.ch>, "Jocelyn Falempe" <jfalempe@...hat.com>,
 "Geert Uytterhoeven" <geert+renesas@...der.be>,
 "Jani Nikula" <jani.nikula@...el.com>,
 "Harry Wentland" <harry.wentland@....com>,
 "Masahiro Yamada" <masahiroy@...nel.org>,
 "Jonathan Cavitt" <jonathan.cavitt@...el.com>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: rework FB_CORE dependency

On Fri, Nov 15, 2024, at 16:54, Thomas Zimmermann wrote:
> Am 15.11.24 um 16:27 schrieb Arnd Bergmann:
>>   
>> @@ -220,7 +221,6 @@ config DRM_CLIENT_LIB
>>   	tristate
>>   	depends on DRM
>>   	select DRM_KMS_HELPER if DRM_FBDEV_EMULATION
>> -	select FB_CORE if DRM_FBDEV_EMULATION
>
> This should remain. More fbdev code will move into drm_fbdev_client.c 
> and that will require FB_CORE.

Got it.

>>   	help
>>   	  This option enables the DRM client library and selects all
>>   	  modules and components according to the enabled clients.
>> @@ -372,6 +372,7 @@ config DRM_GEM_SHMEM_HELPER
>>   	tristate
>>   	depends on DRM && MMU
>>   	select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION
>> +	select FB_CORE if DRM_FBDEV_EMULATION
>
> This select is also needed by DRM_GEM_DMA_HELPER and DRM_GEM_TTM_HELPER.
>
> Please sort these select statements alphabetically.

Sent a v2 now.

     Arnd