linux-kernel - Re: [PATCH] hfs: Fix uninitialized value issue in hfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zzd-2iVB2AtJaxR8@casper.infradead.org>
Date: Fri, 15 Nov 2024 17:03:22 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Suraj Sonawane <surajsonawane0215@...il.com>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	syzbot+18dd03a3fcf0ffe27da0@...kaller.appspotmail.com
Subject: Re: [PATCH] hfs: Fix uninitialized value issue in hfs_iget

On Fri, Nov 15, 2024 at 09:22:31PM +0530, Suraj Sonawane wrote:
> On 23/09/24 23:30, SurajSonawane2415 wrote:
> > Fix uninitialized value issue in hfs_iget by initializing the hfs_cat_rec
> > structure in hfs_lookup.

This doesn't make sense to me.  I don't see how we get to hfs_iget()
with an uninit "rec".

        hfs_cat_rec rec;
...
        res = hfs_brec_read(&fd, &rec, sizeof(rec));
        if (res) {
...
        } else {
                inode = hfs_iget(dir->i_sb, &fd.search_key->cat, &rec);

Unless there's a path in hfs_brec_read() which returns 'success' while
not actually filling in all of 'rec', in which case that's the bug which
needs to be fixed.