linux-kernel - Re: [PATCH v2] nvme-core: auto add the new ns while UUID changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241115170411.GA23437@lst.de>
Date: Fri, 15 Nov 2024 18:04:11 +0100
From: Christoph Hellwig <hch@....de>
To: "brookxu.cn" <brookxu.cn@...il.com>
Cc: kbusch@...nel.org, axboe@...nel.dk, hch@....de, sagi@...mberg.me,
	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nvme-core: auto add the new ns while UUID changed

On Fri, Nov 15, 2024 at 04:37:27PM +0800, brookxu.cn wrote:
> From: "Chunguang.xu" <chunguang.xu@...pee.com>
> 
> Now spdk will change UUID of ns while restarted if we have not
> specified one. At this time, while host try to reconnected to target,
> as UUID have changed, we will remove the old ns, but not add the ns
> with the new UUID.

And that is broken behavior.  The host must assume the namespace has
been deleted and recreated when the eui/nguid/uuid change, and we need
to catch this.  Fix your broken target code instead.