linux-kernel - Re: [PATCH v5 2/2] module: Block a module by TUXEDO from accessing GPL symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D5NGCPSP7EO8.28YI337NY203X@kruces.com>
Date: Sat, 16 Nov 2024 09:15:55 +0100
From: "Daniel Gomez" <d+samsung@...ces.com>
To: "Werner Sembach" <wse@...edocomputers.com>,
 <u.kleine-koenig@...libre.com>, <mcgrof@...nel.org>, <petr.pavlu@...e.com>,
 <samitolvanen@...gle.com>, <da.gomez@...sung.com>,
 <linux-modules@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux@...mhuis.info>, <vv@...edocomputers.com>, <cs@...edo.de>
Cc: Uwe Kleine-König <ukleinek@...nel.org>
Subject: Re: [PATCH v5 2/2] module: Block a module by TUXEDO from accessing
 GPL symbols

On Fri Nov 15, 2024 at 7:50 PM CET, Werner Sembach wrote:
> From: Uwe Kleine-König <ukleinek@...nel.org>
>
> TUXEDO has not yet relicensed a module for GPLv2+ as a reply from former
> contributers the committed code under GPLv3+ is awaited.

FYI, the SPDX identifier GPL-2.0+ is deprecated as of 2.0rc2 [1]. I think you'd
need to use GPL-2.0-or-later [2] instead. And when using the SPDX identifier,
you don't need to include the full text boilerplate in the source of every file
as long as you include a LICENSE file or COPYRIGHT file with a copy of the
license. One example upstream here [3] commit 1a59d1b8e05ea ("treewide: Replace
GPLv2 boilerplate/reference with SPDX - rule 156").

[1] https://spdx.org/licenses/GPL-2.0+.html
[2] https://spdx.org/licenses/GPL-2.0-or-later.html
[3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.12-rc7&id=1a59d1b8e05ea


Daniel
>
> Teach the module loader that this module is not GPLv2 compatible despite
> the declaration to be GPLv2 compatible until the relicensing is complete.
>
> Signed-off-by: Uwe Kleine-König <ukleinek@...nel.org>
> [Remove relicensed modules and accusatory language]
> Signed-off-by: Werner Sembach <wse@...edocomputers.com>
> ---
>  kernel/module/main.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index 905d7b60dd709..df2549352ca8a 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -2029,6 +2029,14 @@ static const char *module_license_offenders[] = {
>  
>  	/* lve claims to be GPL but upstream won't provide source */
>  	"lve",
> +
> +	/*
> +	 * TUXEDO awaits 2 final answers to relicense the last module to GPLv2+
> +	 * See https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers/-/merge_requests/21 ,
> +	 * https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers/-/commit/dd34594ab880ed477bb75725176c3fb9352a07eb ,
> +	 * and https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers/-/commit/c8893684c2f869b2a6b13f1ef1ddeb4922f2ffe3
> +	 */
> +	"clevo_acpi",
>  };
>  
>  /*