linux-kernel - Re: [PATCH v12 2/3] net/9p/usbg: Add new usb gadget function transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZzhWRPDNwu225NWz@codewreck.org>
Date: Sat, 16 Nov 2024 17:22:28 +0900
From: Dominique Martinet <asmadeus@...ewreck.org>
To: Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc: Eric Van Hensbergen <ericvh@...nel.org>,
	Latchesar Ionkov <lucho@...kov.net>,
	Christian Schoenebeck <linux_oss@...debyte.com>,
	Jonathan Corbet <corbet@....net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
	v9fs@...ts.linux.dev, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH v12 2/3] net/9p/usbg: Add new usb gadget function
 transport

Michael Grzeschik wrote on Sun, Sep 01, 2024 at 09:11:17PM +0200:
> diff --git a/net/9p/Kconfig b/net/9p/Kconfig
> index bcdab9c23b402..2d7e596e22c3f 100644
> --- a/net/9p/Kconfig
> +++ b/net/9p/Kconfig
> @@ -40,6 +40,12 @@ config NET_9P_XEN
>  	  This builds support for a transport for 9pfs between
>  	  two Xen domains.
>  
> +config NET_9P_USBG
> +	bool "9P USB Gadget Transport"


It's been a while since this got in, but I figured I'd at least start by
getting this built since we got a minor fix recently, and this being a
bool is a bit weird -- any reaosn this wasn't made tristate?

(If NET_9P=m then setting NET_9P_USBG=y doesn't seem to do anything?
while it should be buildable as module, whether NET_9P is m or y)


>From the code there's a module_init and MODULE_ALIAS_9P is set so I
don't see why it wouldn't just work, but I still haven't taken the time
to figure out how to run this in qemu so I can't test this trivial diff:
----
diff --git a/net/9p/Kconfig b/net/9p/Kconfig
index ee967fd25312..97546a6a3475 100644
--- a/net/9p/Kconfig
+++ b/net/9p/Kconfig
@@ -41,7 +41,7 @@ config NET_9P_XEN
          two Xen domains.
 
 config NET_9P_USBG
-       bool "9P USB Gadget Transport"
+       tristate "9P USB Gadget Transport"
        depends on USB_GADGET=y || USB_GADGET=NET_9P
        select CONFIGFS_FS
        select USB_LIBCOMPOSITE

----

Thoughts?
In particular the depends might need adjusting, it's already in an `if
NET_9P` block so just depends on USB_GADGET is probably enough, but I
don't understand the rationale behind USB_GADGET=NET_9P either (can't
have NET_9P=y and USB_GADGET=m ?)


Thanks,
-- 
Dominique