| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <e0d15960-4fb9-4458-b080-89791d2f5d2a@csgroup.eu> Date: Sat, 16 Nov 2024 11:26:51 +0100 From: Christophe Leroy <christophe.leroy@...roup.eu> To: Easwar Hariharan <eahariha@...ux.microsoft.com>, Pablo Neira Ayuso <pablo@...filter.org>, Jozsef Kadlecsik <kadlec@...filter.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Julia Lawall <Julia.Lawall@...ia.fr>, Nicolas Palix <nicolas.palix@...g.fr>, Daniel Mack <daniel@...que.org>, Haojian Zhuang <haojian.zhuang@...il.com>, Robert Jarzmik <robert.jarzmik@...e.fr>, Russell King <linux@...linux.org.uk>, Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev <agordeev@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, Ofir Bitton <obitton@...ana.ai>, Oded Gabbay <ogabbay@...nel.org>, Lucas De Marchi <lucas.demarchi@...el.com>, Thomas Hellström <thomas.hellstrom@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Jeroen de Borst <jeroendb@...gle.com>, Praveen Kaligineedi <pkaligineedi@...gle.com>, Shailend Chand <shailend@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>, James Smart <james.smart@...adcom.com>, Dick Kennedy <dick.kennedy@...adcom.com>, "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, Roger Pau Monné <roger.pau@...rix.com>, Jens Axboe <axboe@...nel.dk>, Kalle Valo <kvalo@...nel.org>, Jeff Johnson <jjohnson@...nel.org>, Catalin Marinas <catalin.marinas@....com>, Andrew Morton <akpm@...ux-foundation.org>, Jack Wang <jinpu.wang@...ud.ionos.com>, Marcel Holtmann <marcel@...tmann.org>, Johan Hedberg <johan.hedberg@...il.com>, Luiz Augusto von Dentz <luiz.dentz@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Florian Fainelli <florian.fainelli@...adcom.com>, Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Xiubo Li <xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>, Josh Poimboeuf <jpoimboe@...nel.org>, Jiri Kosina <jikos@...nel.org>, Miroslav Benes <mbenes@...e.cz>, Petr Mladek <pmladek@...e.com>, Joe Lawrence <joe.lawrence@...hat.com>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Lucas Stach <l.stach@...gutronix.de>, Russell King <linux+etnaviv@...linux.org.uk>, Christian Gmeiner <christian.gmeiner@...il.com>, Louis Peens <louis.peens@...igine.com>, Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, Naveen N Rao <naveen@...nel.org>, Madhavan Srinivasan <maddy@...ux.ibm.com> Cc: netfilter-devel@...r.kernel.org, coreteam@...filter.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, cocci@...ia.fr, linux-arm-kernel@...ts.infradead.org, linux-s390@...r.kernel.org, dri-devel@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org, linux-scsi@...r.kernel.org, xen-devel@...ts.xenproject.org, linux-block@...r.kernel.org, linux-wireless@...r.kernel.org, ath11k@...ts.infradead.org, linux-mm@...ck.org, linux-bluetooth@...r.kernel.org, linux-staging@...ts.linux.dev, linux-rpi-kernel@...ts.infradead.org, ceph-devel@...r.kernel.org, live-patching@...r.kernel.org, linux-sound@...r.kernel.org, etnaviv@...ts.freedesktop.org, oss-drivers@...igine.com, linuxppc-dev@...ts.ozlabs.org, Anna-Maria Behnsen <anna-maria@...utronix.de> Subject: Re: [PATCH v2 03/21] arm: pxa: Convert timeouts to use secs_to_jiffies() Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > [Vous ne recevez pas souvent de courriers de eahariha@...ux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com> > --- > arch/arm/mach-pxa/sharpsl_pm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-pxa/sharpsl_pm.c b/arch/arm/mach-pxa/sharpsl_pm.c > index 72fa2e3fd35318e5a63c121ed7990a56a56b134c..bbbd06bc79bbb94fb258562e5a382acaf3c277b3 100644 > --- a/arch/arm/mach-pxa/sharpsl_pm.c > +++ b/arch/arm/mach-pxa/sharpsl_pm.c > @@ -31,9 +31,9 @@ > /* > * Constants > */ > -#define SHARPSL_CHARGE_ON_TIME_INTERVAL (msecs_to_jiffies(1*60*1000)) /* 1 min */ > -#define SHARPSL_CHARGE_FINISH_TIME (msecs_to_jiffies(10*60*1000)) /* 10 min */ > -#define SHARPSL_BATCHK_TIME (msecs_to_jiffies(15*1000)) /* 15 sec */ > +#define SHARPSL_CHARGE_ON_TIME_INTERVAL (secs_to_jiffies(60)) /* 1 min */ > +#define SHARPSL_CHARGE_FINISH_TIME (secs_to_jiffies(10*60)) /* 10 min */ > +#define SHARPSL_BATCHK_TIME (secs_to_jiffies(15)) /* 15 sec */ This comment is completely useless now. The other ones are probably also kind of useless, everybody knows 1 min = 60 sec. See https://docs.kernel.org/process/coding-style.html#commenting > #define SHARPSL_BATCHK_TIME_SUSPEND (60*10) /* 10 min */ > > #define SHARPSL_WAIT_CO_TIME 15 /* 15 sec */ > > -- > 2.34.1 >
Powered by blists - more mailing lists