linux-kernel - Re: [PATCH v1 1/1] gpio: zevio: Add missed label initialisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mff+1Yau2w2W3MvFVq4e=xBMnGqfOvBPfH9XjsbJWvBvg@mail.gmail.com>
Date: Sat, 16 Nov 2024 15:16:25 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/1] gpio: zevio: Add missed label initialisation

On Fri, Nov 15, 2024 at 1:38 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Initialise the GPIO chip label correctly.
>

Same as altera - please improve the commit message by saying that this
was previously done by gpiolib-of.

Bart

> Fixes: cf8f4462e5fa ("gpio: zevio: drop of_gpio.h header")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/gpio/gpio-zevio.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c
> index 2de61337ad3b..d7230fd83f5d 100644
> --- a/drivers/gpio/gpio-zevio.c
> +++ b/drivers/gpio/gpio-zevio.c
> @@ -11,6 +11,7 @@
>  #include <linux/io.h>
>  #include <linux/mod_devicetable.h>
>  #include <linux/platform_device.h>
> +#include <linux/property.h>
>  #include <linux/slab.h>
>  #include <linux/spinlock.h>
>
> @@ -169,6 +170,7 @@ static const struct gpio_chip zevio_gpio_chip = {
>  /* Initialization */
>  static int zevio_gpio_probe(struct platform_device *pdev)
>  {
> +       struct device *dev = &pdev->dev;
>         struct zevio_gpio *controller;
>         int status, i;
>
> @@ -180,6 +182,10 @@ static int zevio_gpio_probe(struct platform_device *pdev)
>         controller->chip = zevio_gpio_chip;
>         controller->chip.parent = &pdev->dev;
>
> +       controller->chip.label = devm_kasprintf(dev, GFP_KERNEL, "%pfw", dev_fwnode(dev));
> +       if (!controller->chip.label)
> +               return -ENOMEM;
> +
>         controller->regs = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(controller->regs))
>                 return dev_err_probe(&pdev->dev, PTR_ERR(controller->regs),
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>