linux-kernel - [PATCH] 9p/fs: Different branch return the same value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241116152612.2423-1-rexnie3@gmail.com>
Date: Sat, 16 Nov 2024 23:26:12 +0800
From: Rex Nie <rexnie3@...il.com>
To: ericvh@...nel.org,
	lucho@...kov.net,
	asmadeus@...ewreck.org,
	linux_oss@...debyte.com
Cc: linux-kernel@...r.kernel.org,
	Rex Nie <rexnie3@...il.com>
Subject: [PATCH] 9p/fs: Different branch return the same value

The same code is executed when the condition ret < 0 is true or false.
Remove the if branch and just return v9fs_init_inode_cache(). This
does not change the semantics of the original code.

Signed-off-by: Rex Nie <rexnie3@...il.com>
---
 fs/9p/v9fs.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
index 281a1ed03a04..ee0a374e0d9d 100644
--- a/fs/9p/v9fs.c
+++ b/fs/9p/v9fs.c
@@ -661,12 +661,7 @@ static void v9fs_destroy_inode_cache(void)
 
 static int v9fs_cache_register(void)
 {
-	int ret;
-
-	ret = v9fs_init_inode_cache();
-	if (ret < 0)
-		return ret;
-	return ret;
+	return v9fs_init_inode_cache();
 }
 
 static void v9fs_cache_unregister(void)
-- 
2.17.1