linux-kernel - Re: [PATCH] Bluetooth: qca: Support downloading board id specific NVM for WCN6855

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3725b96-4811-4ecb-bad1-1e859b730423@quicinc.com>
Date: Sun, 17 Nov 2024 00:07:05 +0800
From: quic_zijuhu <quic_zijuhu@...cinc.com>
To: Johan Hovold <johan@...nel.org>
CC: Marcel Holtmann <marcel@...tmann.org>,
        Luiz Augusto von Dentz
	<luiz.dentz@...il.com>,
        Zijun Hu <zijun_hu@...oud.com>, <linux-bluetooth@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        "Bjorn
 Andersson" <bjorande@...cinc.com>,
        "Aiqun Yu (Maria)"
	<quic_aiquny@...cinc.com>,
        Cheng Jiang <quic_chejiang@...cinc.com>,
        "Jens
 Glathe" <jens.glathe@...schoolsolutions.biz>,
        Steev Klimaszewski
	<steev@...i.org>
Subject: Re: [PATCH] Bluetooth: qca: Support downloading board id specific NVM
 for WCN6855

On 11/15/2024 6:01 PM, Johan Hovold wrote:
> On Wed, Nov 13, 2024 at 10:26:56PM -0800, Zijun Hu wrote:
>> Download board id specific NVM instead of default for WCN6855 if board
>> id is available, and that is required by Lenovo ThinkPad X13s.
>>
>> Cc: Bjorn Andersson <bjorande@...cinc.com>
>> Cc: Aiqun Yu (Maria) <quic_aiquny@...cinc.com>
>> Cc: Cheng Jiang <quic_chejiang@...cinc.com>
>> Cc: Johan Hovold <johan@...nel.org>
>> Cc: Jens Glathe <jens.glathe@...schoolsolutions.biz>
>> Cc: Steev Klimaszewski <steev@...i.org>
>> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> 
> This works like a charm on my X13s which has the GF variant.
> 
> Unlike with the "default" NVM file, the range is excellent with the
> board-specific file now pushed to linux-firmware (similar to what I see
> when using the Windows driver NVM file). Specifically, the range with
> the headphones I use for testing increases from about two meters to 20 m
> (around a bend).
> 
> Even if these NVM files didn't make it into the November release of
> linux-firmware and therefore won't make it into the distros for another
> month, I think we should mark this one as a fix and backport it to
> stable as soon as possible.
> 
> Zijun, could you amend the commit message with some details about why
> this needs to be fixed and backported (e.g. refer to my range example
> above)?
> 

will do it within v2 as you suggest.

> Fixes: 095327fede00 ("Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855")
> Cc: stable@...r.kernel.org	# 6.4
> 
> It's possible to add a comment after the stable tag to delay backporting
> until the next linux-firmware release, but in this case it may be better
> to break existing setups and force people to update to the correct radio
> calibration data.
> 

i would like to temporarily add fallback logic within v2, then i will
help to backport it ASAP without breaking existing setups even if the
current default NVM are not for WCN6855.

> Either way:
> 
> Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
> Tested-by: Johan Hovold <johan+linaro@...nel.org>

thank you johan for verification and suggestion.
(^^)(^^)

> 
> Johan