linux-kernel - Re: [PATCH 1/1] PCI/bwctrl: Remove IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241116161010.GA2125250@bhelgaas>
Date: Sat, 16 Nov 2024 10:10:10 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Stefan Wahren <wahrenst@....net>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Lukas Wunner <lukas@...ner.de>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	linux-pci@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] PCI/bwctrl: Remove IRQF_ONESHOT and handle hardirqs
 instead

On Sat, Nov 16, 2024 at 04:40:51PM +0200, Ilpo Järvinen wrote:
> On Fri, 15 Nov 2024, Bjorn Helgaas wrote:
> 
> > On Fri, Nov 15, 2024 at 06:57:17PM +0200, Ilpo Järvinen wrote:
> > > bwctrl cannot use IRQF_ONESHOT because it shares interrupt with other
> > > service drivers that are not using IRQF_ONESHOT nor compatible with it.
> > > 
> > > Remove IRQF_ONESHOT from bwctrl and convert the irq thread to hardirq
> > > handler. Rename the handler to pcie_bwnotif_irq() to indicate its new
> > > purpose.
> > > 
> > > The IRQ handler is simple enough to not require not require other
> > > changes.
> > > 
> > > Fixes: 058a4cb11620 ("PCI/bwctrl: Re-add BW notification portdrv as PCIe BW controller")
> > > Reported-by: Stefan Wahren <wahrenst@....net>
> > > Link: https://lore.kernel.org/linux-pci/dcd660fd-a265-4f47-8696-776a85e097a0@gmx.net/
> > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> > 
> > Squashed into 058a4cb11620, thanks!
> > 
> > Also added your tested-by, Stefan, thanks very much for doing that!
> 
> Hi Bjorn,
> 
> You might want to also remove "3) ..." part from the commit message as it 
> still refers to threaded IRQ and IRQF_ONESHOT so it won't confuse anybody 
> when looking at this years from now :-).

Removed, thanks for that!