linux-kernel - Re: [PATCH] libbpf: Change hash_combine parameters from long to unsigned long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b992d5ec-c1eb-4ab2-b2df-2464d9a2a847@linux.dev>
Date: Sat, 16 Nov 2024 10:54:09 -0800
From: Yonghong Song <yonghong.song@...ux.dev>
To: Sidong Yang <sidong.yang@...iosa.ai>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman
 <eddyz87@...il.com>, Song Liu <song@...nel.org>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, Andrii Nakryiko <andrii.nakryiko@...il.com>,
 bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libbpf: Change hash_combine parameters from long to
 unsigned long




On 11/16/24 12:10 AM, Sidong Yang wrote:
> The hash_combine() could be trapped when compiled with sanitizer like "zig cc"
> or clang with signed-integer-overflow option. This patch parameters and return
> type to unsigned long to remove the potential overflow.
>
> Signed-off-by: Sidong Yang <sidong.yang@...iosa.ai>

Acked-by: Yonghong Song <yonghong.song@...ux.dev>