linux-kernel - Re: [PATCHv2 5.15] udf: Allocate name buffer in directory iterator on heap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241116040450.GN1458936@google.com>
Date: Sat, 16 Nov 2024 13:04:50 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Jan Kara <jack@...e.cz>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>, stable@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCHv2 5.15] udf: Allocate name buffer in directory iterator
 on heap

On (24/11/15 13:07), Jan Kara wrote:
> On Fri 15-11-24 15:08:48, Sergey Senozhatsky wrote:
> > From: Jan Kara <jack@...e.cz>
> > 
> > [ Upstream commit 0aba4860b0d0216a1a300484ff536171894d49d8 ]
> > 
> > Currently we allocate name buffer in directory iterators (struct
> > udf_fileident_iter) on stack. These structures are relatively large
> > (some 360 bytes on 64-bit architectures). For udf_rename() which needs
> > to keep three of these structures in parallel the stack usage becomes
> > rather heavy - 1536 bytes in total. Allocate the name buffer in the
> > iterator from heap to avoid excessive stack usage.
> > 
> > Link: https://lore.kernel.org/all/202212200558.lK9x1KW0-lkp@intel.com
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Jan Kara <jack@...e.cz>
> > [ senozhatsky: explicitly include slab.h to address build
> >   failure reported by sashal@ ]
> > Signed-off-by: Sergey Senozhatsky <senozhatsky@...omium.org>
> 
> Mauke beat you to this, Greg already queued up his patches :)

Story of my life :)

> [1] https://lore.kernel.org/all/20241114212657.306989-1-hauke@hauke-m.de

Awesome, thanks everyone!