linux-kernel - Re: [PATCH] ata: Constify struct pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <caafe4bf-7854-4ca9-b782-f317599ed1c8@omp.ru>
Date: Sun, 17 Nov 2024 16:04:15 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, Damien Le Moal
	<dlemoal@...nel.org>, Niklas Cassel <cassel@...nel.org>
CC: <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
	<linux-ide@...r.kernel.org>
Subject: Re: [PATCH] ata: Constify struct pci_device_id

On 11/16/24 12:08 AM, Christophe JAILLET wrote:

> 'struct pci_device_id' is not modified in these drivers.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
> 
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>    4245	   1454	      4	   5703	   1647	drivers/ata/ata_generic.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>    4725	    974	      4	   5703	   1647	drivers/ata/ata_generic.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

[...]
   No longer an "official" PATA reviewer, but FWIW:

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

MBR, Sergey