| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202411170802.SnHuptE7-lkp@intel.com>
Date: Sun, 17 Nov 2024 08:34:31 +0800
From: kernel test robot <lkp@...el.com>
To: Saravana Kannan <saravanak@...gle.com>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
Valentin Schneider <vschneid@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, Saravana Kannan <saravanak@...gle.com>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Marek Vasut <marex@...x.de>, Bird@...gle.com,
Tim <Tim.Bird@...y.com>, kernel-team@...roid.com,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 5/5] PM: sleep: Spread out async kworker threads
during dpm_resume*() phases
Hi Saravana,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge tip/sched/core amd-pstate/linux-next amd-pstate/bleeding-edge linus/master v6.12-rc7 next-20241115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Saravana-Kannan/PM-sleep-Fix-runtime-PM-issue-in-dpm_resume/20241115-183855
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20241114220921.2529905-6-saravanak%40google.com
patch subject: [PATCH v1 5/5] PM: sleep: Spread out async kworker threads during dpm_resume*() phases
config: arm-s3c6400_defconfig (https://download.01.org/0day-ci/archive/20241117/202411170802.SnHuptE7-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411170802.SnHuptE7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411170802.SnHuptE7-lkp@intel.com/
All errors (new ones prefixed by >>):
arm-linux-gnueabi-ld: kernel/power/suspend.o: in function `suspend_enter':
>> kernel/power/suspend.c:485:(.text+0x2f4): undefined reference to `sched_set_energy_aware'
>> arm-linux-gnueabi-ld: kernel/power/suspend.c:485:(.text+0x48c): undefined reference to `sched_set_energy_aware'
arm-linux-gnueabi-ld: kernel/power/suspend.c:485:(.text+0x4c0): undefined reference to `sched_set_energy_aware'
arm-linux-gnueabi-ld: kernel/power/suspend.c:485:(.text+0x4d0): undefined reference to `sched_set_energy_aware'
arm-linux-gnueabi-ld: kernel/power/suspend.o: in function `suspend_devices_and_enter':
kernel/power/suspend.c:538:(.text+0x748): undefined reference to `sched_set_energy_aware'
vim +485 kernel/power/suspend.c
401
402 /**
403 * suspend_enter - Make the system enter the given sleep state.
404 * @state: System sleep state to enter.
405 * @wakeup: Returns information that the sleep state should not be re-entered.
406 *
407 * This function should be called after devices have been suspended.
408 */
409 static int suspend_enter(suspend_state_t state, bool *wakeup)
410 {
411 int error;
412
413 error = platform_suspend_prepare(state);
414 if (error)
415 goto Platform_finish;
416
417 error = dpm_suspend_late(PMSG_SUSPEND);
418 if (error) {
419 pr_err("late suspend of devices failed\n");
420 goto Platform_finish;
421 }
422 error = platform_suspend_prepare_late(state);
423 if (error)
424 goto Devices_early_resume;
425
426 error = dpm_suspend_noirq(PMSG_SUSPEND);
427 if (error) {
428 pr_err("noirq suspend of devices failed\n");
429 goto Platform_early_resume;
430 }
431 error = platform_suspend_prepare_noirq(state);
432 if (error)
433 goto Platform_wake;
434
435 if (suspend_test(TEST_PLATFORM))
436 goto Platform_wake;
437
438 if (state == PM_SUSPEND_TO_IDLE) {
439 s2idle_loop();
440 goto Platform_wake;
441 }
442
443 error = pm_sleep_disable_secondary_cpus();
444 if (error || suspend_test(TEST_CPUS))
445 goto Enable_cpus;
446
447 arch_suspend_disable_irqs();
448 BUG_ON(!irqs_disabled());
449
450 system_state = SYSTEM_SUSPEND;
451
452 error = syscore_suspend();
453 if (!error) {
454 *wakeup = pm_wakeup_pending();
455 if (!(suspend_test(TEST_CORE) || *wakeup)) {
456 trace_suspend_resume(TPS("machine_suspend"),
457 state, true);
458 error = suspend_ops->enter(state);
459 trace_suspend_resume(TPS("machine_suspend"),
460 state, false);
461 } else if (*wakeup) {
462 error = -EBUSY;
463 }
464 syscore_resume();
465 }
466
467 system_state = SYSTEM_RUNNING;
468
469 arch_suspend_enable_irqs();
470 BUG_ON(irqs_disabled());
471
472 Enable_cpus:
473 pm_sleep_enable_secondary_cpus();
474
475 Platform_wake:
476 platform_resume_noirq(state);
477 /*
478 * We do this only for resume instead of suspend and resume for these
479 * reasons:
480 * - Performance is more important than power for resume.
481 * - Power spent entering suspend is more important for suspend. Also,
482 * stangely, disabling EAS was making suspent a few milliseconds
483 * slower in my testing.
484 */
> 485 sched_set_energy_aware(0);
486 dpm_resume_noirq(PMSG_RESUME);
487
488 Platform_early_resume:
489 platform_resume_early(state);
490
491 Devices_early_resume:
492 dpm_resume_early(PMSG_RESUME);
493
494 Platform_finish:
495 platform_resume_finish(state);
496 return error;
497 }
498
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists