linux-kernel - Re: [PATCH 2/5] scsi: ufs: qcom: Only free platform MSIs when ESI is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3bc8ab6266c7a1c54bbc0d6eca53019734029cbb.camel@gmail.com>
Date: Sun, 17 Nov 2024 18:37:40 +0100
From: Bean Huo <huobean@...il.com>
To: manivannan.sadhasivam@...aro.org, Alim Akhtar <alim.akhtar@...sung.com>,
  Avri Altman <avri.altman@....com>, Bart Van Assche <bvanassche@....org>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>, "Martin K.
 Petersen" <martin.petersen@...cle.com>, Mike Bi <mikebi@...ron.com>, Bean
 Huo <beanhuo@...ron.com>, Thomas Weißschuh
 <linux@...ssschuh.net>,  Luca Porzio <lporzio@...ron.com>, Asutosh Das
 <quic_asutoshd@...cinc.com>, Can Guo <quic_cang@...cinc.com>,  Pedro Sousa
 <pedrom.sousa@...opsys.com>, Krzysztof Kozlowski <krzk@...nel.org>, Peter
 Wang <peter.wang@...iatek.com>, Stanley Jhu <chu.stanley@...il.com>,
 Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, Orson Zhai
 <orsonzhai@...il.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>, Chunyan
 Zhang <zhang.lyra@...il.com>,  Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
 Santosh Y <santoshsy@...il.com>, Namjae Jeon <linkinjeon@...il.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, linux-mediatek@...ts.infradead.org, 
	linux-renesas-soc@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 2/5] scsi: ufs: qcom: Only free platform MSIs when ESI
 is enabled

On Mon, 2024-11-11 at 23:18 +0530, Manivannan Sadhasivam via B4 Relay
wrote:
> Otherwise, it will result in a NULL pointer dereference as below:
> 
> Unable to handle kernel NULL pointer dereference at virtual address
> 0000000000000008
> Call trace:
>  mutex_lock+0xc/0x54
>  platform_device_msi_free_irqs_all+0x14/0x20
>  ufs_qcom_remove+0x34/0x48 [ufs_qcom]
>  platform_remove+0x28/0x44
>  device_remove+0x4c/0x80
>  device_release_driver_internal+0xd8/0x178
>  driver_detach+0x50/0x9c
>  bus_remove_driver+0x6c/0xbc
>  driver_unregister+0x30/0x60
>  platform_driver_unregister+0x14/0x20
>  ufs_qcom_pltform_exit+0x18/0xb94 [ufs_qcom]
>  __arm64_sys_delete_module+0x180/0x260
>  invoke_syscall+0x44/0x100
>  el0_svc_common.constprop.0+0xc0/0xe0
>  do_el0_svc+0x1c/0x28
>  el0_svc+0x34/0xdc
>  el0t_64_sync_handler+0xc0/0xc4
>  el0t_64_sync+0x190/0x194
> 
> Cc: stable@...r.kernel.org # 6.3
> Fixes: 519b6274a777 ("scsi: ufs: qcom: Add MCQ ESI config vendor
> specific ops")
> Signed-off-by: Manivannan Sadhasivam
> <manivannan.sadhasivam@...aro.org>

Reviewed-by: Bean Huo <beanhuo@...ron.com>