linux-kernel - Re: [PATCH] exec: remove legacy custom binfmt modules autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173181935997.601589.16672643288623371390.b4-ty@kernel.org>
Date: Sat, 16 Nov 2024 20:56:02 -0800
From: Kees Cook <kees@...nel.org>
To: ebiederm@...ssion.com,
	viro@...iv.linux.org.uk,
	brauner@...nel.org,
	jack@...e.cz,
	linux-kernel@...r.kernel.org,
	Nir Lichtman <nir@...htman.org>
Cc: Kees Cook <kees@...nel.org>
Subject: Re: [PATCH] exec: remove legacy custom binfmt modules autoloading

On Sat, 16 Nov 2024 23:13:23 +0000, Nir Lichtman wrote:
> Problem: The search binary handler logic contains legacy code
> to handle automatically loading kernel modules of unsupported
> binary formats.
> This logic is a leftover from a.out-to-ELF transition.
> After removal of a.out support, this code has no use anymore.
> 
> Solution: Clean up this code from the search binary handler,
> also remove the line initialising retval to -ENOENT and instead
> just return -ENOEXEC if the flow has reached the end of the func.
> 
> [...]

And it removes a goto. :)

Applied to for-next/execve, thanks!

[1/1] exec: remove legacy custom binfmt modules autoloading
      https://git.kernel.org/kees/c/8c9870077aac

Take care,

-- 
Kees Cook