linux-kernel - Re: [PATCH 06/22] iio: accel: adxl345: add function to switch measuring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202411171333.4V4FcJFa-lkp@intel.com>
Date: Sun, 17 Nov 2024 13:37:41 +0800
From: kernel test robot <lkp@...el.com>
To: Lothar Rubusch <l.rubusch@...il.com>, lars@...afoo.de,
	Michael.Hennerich@...log.com, jic23@...nel.org,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, l.rubusch@....ch,
	Lothar Rubusch <l.rubusch@...il.com>
Subject: Re: [PATCH 06/22] iio: accel: adxl345: add function to switch
 measuring

Hi Lothar,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v6.12-rc7 next-20241115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lothar-Rubusch/iio-accel-adxl345-fix-comment-on-probe/20241115-190245
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20241114231002.98595-7-l.rubusch%40gmail.com
patch subject: [PATCH 06/22] iio: accel: adxl345: add function to switch measuring
config: arm-randconfig-002-20241117 (https://download.01.org/0day-ci/archive/20241117/202411171333.4V4FcJFa-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411171333.4V4FcJFa-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411171333.4V4FcJFa-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/iio/accel/adxl345_core.c:142: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * For lowest power operation, standby mode can be used. In standby mode,


vim +142 drivers/iio/accel/adxl345_core.c

   140	
   141	/**
 > 142	 * For lowest power operation, standby mode can be used. In standby mode,
   143	 * current consumption is supposed to be reduced to 0.1uA (typical). In this
   144	 * mode no measurements are made. Placing the device into standby mode
   145	 * preserves the contents of FIFO.
   146	 *
   147	 * Unloading the driver puts the device in standby mode (measuring off).
   148	 *
   149	 * @st: The device data.
   150	 * @en: Enable measurements, else standby mode.
   151	 */
   152	static int adxl345_set_measure_en(struct adxl34x_state *st, bool en)
   153	{
   154		unsigned int val = 0;
   155		int ret;
   156	
   157		val = (en) ? ADXL345_POWER_CTL_MEASURE : ADXL345_POWER_CTL_STANDBY;
   158		ret = regmap_write(st->regmap, ADXL345_REG_POWER_CTL, val);
   159		if (ret)
   160			return -EINVAL;
   161	
   162		return 0;
   163	}
   164	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki