linux-kernel - Re: [PATCH net-next v8 2/2] binder: report txn errors via generic netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202411171514.Vfp0RaLK-lkp@intel.com>
Date: Sun, 17 Nov 2024 15:23:42 +0800
From: kernel test robot <lkp@...el.com>
To: Li Li <dualli@...omium.org>, dualli@...gle.com, corbet@....net,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, donald.hunter@...il.com,
	gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com,
	maco@...roid.com, joel@...lfernandes.org, brauner@...nel.org,
	cmllamas@...gle.com, surenb@...gle.com, arnd@...db.de,
	masahiroy@...nel.org, bagasdotme@...il.com, horms@...nel.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	netdev@...r.kernel.org, hridya@...gle.com, smoreland@...gle.com
Cc: oe-kbuild-all@...ts.linux.dev, kernel-team@...roid.com
Subject: Re: [PATCH net-next v8 2/2] binder: report txn errors via generic
 netlink

Hi Li,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 31a1f8752f7df7e3d8122054fbef02a9a8bff38f]

url:    https://github.com/intel-lab-lkp/linux/commits/Li-Li/tools-ynl-gen-allow-uapi-headers-in-sub-dirs/20241114-033521
base:   31a1f8752f7df7e3d8122054fbef02a9a8bff38f
patch link:    https://lore.kernel.org/r/20241113193239.2113577-3-dualli%40chromium.org
patch subject: [PATCH net-next v8 2/2] binder: report txn errors via generic netlink
config: arc-randconfig-001-20241117 (https://download.01.org/0day-ci/archive/20241117/202411171514.Vfp0RaLK-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411171514.Vfp0RaLK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411171514.Vfp0RaLK-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/android/binder.c:1977: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb'
   drivers/android/binder.c:1977: warning: Excess struct member 'fd' description in 'binder_task_work_cb'
   drivers/android/binder.c:2428: warning: Function parameter or struct member 'offset' not described in 'binder_ptr_fixup'
   drivers/android/binder.c:2428: warning: Function parameter or struct member 'skip_size' not described in 'binder_ptr_fixup'
   drivers/android/binder.c:2428: warning: Function parameter or struct member 'fixup_data' not described in 'binder_ptr_fixup'
   drivers/android/binder.c:2428: warning: Function parameter or struct member 'node' not described in 'binder_ptr_fixup'
   drivers/android/binder.c:2448: warning: Function parameter or struct member 'offset' not described in 'binder_sg_copy'
   drivers/android/binder.c:2448: warning: Function parameter or struct member 'sender_uaddr' not described in 'binder_sg_copy'
   drivers/android/binder.c:2448: warning: Function parameter or struct member 'length' not described in 'binder_sg_copy'
   drivers/android/binder.c:2448: warning: Function parameter or struct member 'node' not described in 'binder_sg_copy'
   drivers/android/binder.c:4180: warning: Function parameter or struct member 'thread' not described in 'binder_free_buf'
>> drivers/android/binder.c:7161: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Add a binder device to binder_devices


vim +7161 drivers/android/binder.c

  7159	
  7160	/**
> 7161	 * Add a binder device to binder_devices
  7162	 * @device: the new binder device to add to the global list
  7163	 *
  7164	 * Not reentrant as the list is not protected by any locks
  7165	 */
  7166	void binder_add_device(struct binder_device *device)
  7167	{
  7168		hlist_add_head(&device->hlist, &binder_devices);
  7169	}
  7170	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki