linux-kernel - Re: [PATCH] ARM: dts: socfpga: sodia: Fix mdio bus probe and PHY ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABMQnVK_RUC84QQ5zb+ZpuMOZcFMNV6HzEYAfmX4bOrRm+rvTw@mail.gmail.com>
Date: Sun, 17 Nov 2024 17:53:51 +0900
From: Nobuhiro Iwamatsu <iwamatsu@...auri.org>
To: dinguyen@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org, robh+dt@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org
Subject: Re: [PATCH] ARM: dts: socfpga: sodia: Fix mdio bus probe and PHY ID

Hi Dinh,

Please check and apply this patch?

Thanks,
  Nobuhiro

2024年10月4日(金) 15:16 Nobuhiro Iwamatsu <iwamatsu@...auri.org>:
>
> From: Nobuhiro Iwamatsu <iwamatsu@...auri.org>
>
> On SoCFPGA/Sodia board, mdio bus cannot be probed, so the PHY cannot be
> found and the network device does not work.
>
> ```
> stmmaceth ff702000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19)
> ```
>
> To probe the mdio bus, add "snps,dwmac-mdio" as compatible string of the
> mdio bus. Also the PHY ID connected to this board is 4. Therefore, change
> to 4.
>
> Fixes: 8fbc10b995a5 ("net: stmmac: check fwnode for phy device before scanning for phy")
> Cc: stable@...r.kernel.org # 6.3+
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@...auri.org>
> ---
>  arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
> index ce0d6514eeb571..e4794ccb8e413f 100644
> --- a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
> +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
> @@ -66,8 +66,10 @@ &gmac1 {
>         mdio0 {
>                 #address-cells = <1>;
>                 #size-cells = <0>;
> -               phy0: ethernet-phy@0 {
> -                       reg = <0>;
> +               compatible = "snps,dwmac-mdio";
> +
> +               phy0: ethernet-phy@4 {
> +                       reg = <4>;
>                         rxd0-skew-ps = <0>;
>                         rxd1-skew-ps = <0>;
>                         rxd2-skew-ps = <0>;
> --
> 2.45.2
>


-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org / kernel.org}
   GPG ID: 32247FBB40AD1FA6