linux-kernel - Re: [PATCH] sched_ext: fix application of sizeof to pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9f86b63-6645-49e8-88d5-a5dbab2aaccd@web.de>
Date: Mon, 18 Nov 2024 18:30:53 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: guanjing@...s.chinamobile.com, Barret Rhoden <brho@...gle.com>,
 David Vernet <void@...ifault.com>, Hao Luo <haoluo@...gle.com>,
 Josh Don <joshdon@...gle.com>, Tejun Heo <tj@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] sched_ext: fix application of sizeof to pointer

> sizeof when applied to a pointer typed expression gives the size of
> the pointer.
>
> The proper fix in this particular case is to code sizeof(cpu_set_t)
> instead of sizeof(cpuset).
…

I suggest to reconsider this view once more.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.12#n941

Would the specification “sizeof(*cpuset)” be more appropriate here?

Regards,
Markus