linux-kernel - Re: [PATCH v1 1/1] s390/vfio-ap: remove gmap_convert_to_secure from vfio_ap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241118200546.7bf584f4.pasic@linux.ibm.com>
Date: Mon, 18 Nov 2024 20:05:46 +0100
From: Halil Pasic <pasic@...ux.ibm.com>
To: Claudio Imbrenda <imbrenda@...ux.ibm.com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-s390@...r.kernel.org, akrowiak@...ux.ibm.com,
        jjherne@...ux.ibm.com, freude@...ux.ibm.com, hca@...ux.ibm.com,
        gor@...ux.ibm.com, agordeev@...ux.ibm.com, borntraeger@...ibm.com,
        svens@...ux.ibm.com, frankja@...ux.ibm.com, nrb@...ux.ibm.com,
        nsg@...ux.ibm.com, seiden@...ux.ibm.com,
        Halil Pasic <pasic@...ux.ibm.com>
Subject: Re: [PATCH v1 1/1] s390/vfio-ap: remove gmap_convert_to_secure from
 vfio_ap_ops

On Fri, 15 Nov 2024 14:56:11 +0100
Claudio Imbrenda <imbrenda@...ux.ibm.com> wrote:

> If the page has been exported, do not re-import it. Imports should
> only be triggered by the guest. The guest will import the page
> automatically when it will need it again, there is no advantage in
> importing it manually.
> 
> Moreover, vfio_pin_pages() will take an extra reference on the page and
> thus will cause the import to always fail. The extra reference would be
> dropped only after pointlessly trying to import the page.
> 
> Fixes: f88fb1335733 ("s390/vfio-ap: make sure nib is shared")
> Signed-off-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>

Reviewed-by: Halil Pasic <pasic@...ux.ibm.com>