Message-ID: <87plms51w4.fsf@intel.com>
Date: Mon, 18 Nov 2024 11:26:03 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, Laurent Pinchart
 <laurent.pinchart@...asonboard.com>
Cc: Rodrigo Vivi <rodrigo.vivi@...el.com>, Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin <tursulin@...ulin.net>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Maarten
 Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Karol
 Herbst <kherbst@...hat.com>, Lyude Paul <lyude@...hat.com>, Danilo
 Krummrich <dakr@...hat.com>, Harry Wentland <harry.wentland@....com>, Leo
 Li <sunpeng.li@....com>, Rodrigo Siqueira <Rodrigo.Siqueira@....com>, Alex
 Deucher <alexander.deucher@....com>, Christian König
 <christian.koenig@....com>, Xinhui Pan <Xinhui.Pan@....com>, Alain Volmat
 <alain.volmat@...s.st.com>, Raphael Gallais-Pou <rgallaispou@...il.com>,
 Liviu Dudau <liviu.dudau@....com>, Andrzej Hajda
 <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>,
 Robert Foss <rfoss@...nel.org>, Jonas Karlman <jonas@...boo.se>, Jernej
 Skrabec <jernej.skrabec@...il.com>, Peter Senna Tschudin
 <peter.senna@...il.com>, Ian Ray <ian.ray@...com>, Martyn Welch
 <martyn.welch@...labora.co.uk>, Inki Dae <inki.dae@...sung.com>, Seung-Woo
 Kim <sw0312.kim@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com>,
 Krzysztof Kozlowski <krzk@...nel.org>, Alim Akhtar
 <alim.akhtar@...sung.com>, Stefan Agner <stefan@...er.ch>, Alison Wang
 <alison.wang@....com>, Patrik Jakobsson <patrik.r.jakobsson@...il.com>,
 Philipp Zabel <p.zabel@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
 <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Rob Clark
 <robdclark@...il.com>, Abhinav Kumar <quic_abhinavk@...cinc.com>, Sean
 Paul <sean@...rly.run>, Marijn Suijten <marijn.suijten@...ainline.org>,
 Dave Airlie <airlied@...hat.com>, Gerd Hoffmann <kraxel@...hat.com>, Sandy
 Huang <hjc@...k-chips.com>, Heiko Stübner
 <heiko@...ech.de>, Andy Yan
 <andy.yan@...k-chips.com>, Chen-Yu Tsai <wens@...e.org>, Samuel Holland
 <samuel@...lland.org>, Thierry Reding <thierry.reding@...il.com>, Mikko
 Perttunen <mperttunen@...dia.com>, Jonathan Hunter <jonathanh@...dia.com>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>, Maíra
 Canal
 <mcanal@...lia.com>, Raspberry Pi Kernel Maintenance
 <kernel-list@...pberrypi.com>, Gurchetan Singh
 <gurchetansingh@...omium.org>, Chia-I Wu <olvaffe@...il.com>, Zack Rusin
 <zack.rusin@...adcom.com>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, intel-gfx@...ts.freedesktop.org,
 intel-xe@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, nouveau@...ts.freedesktop.org,
 amd-gfx@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org,
 virtualization@...ts.linux.dev, spice-devel@...ts.freedesktop.org,
 linux-rockchip@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
 linux-tegra@...r.kernel.org
Subject: Re: [PATCH 1/5] drm/encoder_slave: make mode_valid accept const
 struct drm_display_mode

On Mon, 18 Nov 2024, Dmitry Baryshkov <dmitry.baryshkov@...aro.org> wrote:
> On Mon, 18 Nov 2024 at 01:33, Laurent Pinchart
> <laurent.pinchart@...asonboard.com> wrote:
>>
>> On Mon, Nov 18, 2024 at 01:22:12AM +0200, Dmitry Baryshkov wrote:
>> > On Sun, 17 Nov 2024 at 22:54, Laurent Pinchart wrote:
>> > > On Fri, Nov 15, 2024 at 11:09:26PM +0200, Dmitry Baryshkov wrote:
>> > > > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge
>> > > > accept const struct drm_display_mode argument. Change the mode_valid
>> > > > callback of drm_encoder_slave to also accept const argument.
>> > > >
>> > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>> > >
>> > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
>> > >
>> > > On a side note, there's only two I2C slave encoder drivers left... I
>> > > wonder if we could so something about them. The ch7006 and sil164
>> > > drivers seem to be used by nouveau only, could they be moved to
>> > > drivers/gpu/drm/nouveau/ ? We would move the whole drm_encoder_slave
>> > > implementation there too, and leave it to die (or get taken out of limbo
>> > > and fixed) with dispnv04.
>> >
>> > Or it might be better to switch to drm_bridge. Currently we also have
>> > sil164 (sub)drivers in ast and i915 drivers. I don't know if there is
>> > any common code to share or not. If there is some, it might be nice to
>> > use common framework.
>>
>> That would require porting nouveau and i915 to drm_bridge. As much as
>> I'd love to see that happening, I won't hold my breath.
>
> Me neither. Probably moving those two and drm_encoder_slave to nouveau
> is really the best course for now.

Granted, the dvo part of i915 is ugly, but it's also only relevant for
the oldest hardware i915 supports. Like 20 years old. Not sure there's
much return on investment in big refactoring, more risk that it breaks
without nobody noticing. Just let it be in i915?

BR,
Jani.



-- 
Jani Nikula, Intel

Powered by blists - more mailing lists