[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241118100039.GB30268@pendragon.ideasonboard.com>
Date: Mon, 18 Nov 2024 12:00:39 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Shu-hsiang Yang <Shu-hsiang.Yang@...iatek.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Sumit Semwal <sumit.semwal@...aro.org>,
Christian Konig <christian.koenig@....com>,
linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, dri-devel@...ts.freedesktop.org,
linaro-mm-sig@...ts.linaro.org,
Project_Global_Chrome_Upstream_Group@...iatek.com,
yaya.chang@...iatek.com, teddy.chen@...iatek.com,
hidenorik@...omium.org, yunkec@...omium.org,
shun-yi.wang@...iatek.com
Subject: Re: [PATCH v1 00/10] Add MediaTek ISP7 camera system driver
Hi Shu-hsiang,
On Wed, Oct 09, 2024 at 07:15:41PM +0800, Shu-hsiang Yang wrote:
> Based on linux-next/master, tag: next-20241008
>
> The patch set adds the MediaTek ISP7.x camera system hardware driver.
>
> This driver sets up ISP hardware, handles interrupts, and initializes
> V4L2 device nodes and functions. Moreover, implement V4L2 standard
> video driver that utilizes media framework APIs. It also connects
> the sensors and ISP, bridging with the seninf interface. Communicate
> with SCP co-processor to compose ISP registers in the firmware.
>
> These patches include CSI received data from sensors, sensor interface
> bridge, raw/YUV image pre-processing, ISP utility and ISP control parts.
>
> Thank you for reviewing these patches.
Could you please include the v4l2-compliance report for the driver in
the cover letter of the next version ? This is required for all new
drivers. Please use the very latest version of v4l2-compliance, compiled
from the master branch of v4l-utils.
> Shu-hsiang Yang (10):
> dt-bindings: media: mediatek: add camsys device
> media: platform: mediatek: add seninf controller
> media: platform: mediatek: add isp_7x seninf unit
> media: platform: mediatek: add isp_7x cam-raw unit
> media: platform: mediatek: add isp_7x camsys unit
> media: platform: mediatek: add isp_7x utility
> media: platform: mediatek: add isp_7x video ops
> media: platform: mediatek: add isp_7x state ctrl
> media: platform: mediatek: add isp_7x build config
> uapi: linux: add mediatek isp_7x camsys user api
>
> .../media/mediatek/mediatek,cam-raw.yaml | 169 +
> .../media/mediatek/mediatek,cam-yuv.yaml | 148 +
> .../media/mediatek/mediatek,camisp.yaml | 71 +
> .../media/mediatek/mediatek,seninf-core.yaml | 106 +
> .../media/mediatek/mediatek,seninf.yaml | 88 +
> drivers/media/platform/mediatek/Kconfig | 1 +
> drivers/media/platform/mediatek/Makefile | 2 +
> drivers/media/platform/mediatek/isp/Kconfig | 21 +
> .../platform/mediatek/isp/isp_7x/Makefile | 7 +
> .../mediatek/isp/isp_7x/camsys/Makefile | 16 +
> .../isp_7x/camsys/kd_imgsensor_define_v4l2.h | 87 +
> .../mediatek/isp/isp_7x/camsys/mtk_cam-ctrl.c | 1797 ++++++
> .../mediatek/isp/isp_7x/camsys/mtk_cam-ctrl.h | 140 +
> .../isp/isp_7x/camsys/mtk_cam-debug.c | 1271 ++++
> .../isp/isp_7x/camsys/mtk_cam-debug.h | 273 +
> .../mediatek/isp/isp_7x/camsys/mtk_cam-defs.h | 168 +
> .../isp/isp_7x/camsys/mtk_cam-dmadbg.h | 721 +++
> .../isp/isp_7x/camsys/mtk_cam-feature.c | 40 +
> .../isp/isp_7x/camsys/mtk_cam-feature.h | 26 +
> .../mediatek/isp/isp_7x/camsys/mtk_cam-fmt.h | 87 +
> .../mediatek/isp/isp_7x/camsys/mtk_cam-ipi.h | 233 +
> .../isp/isp_7x/camsys/mtk_cam-meta-mt8188.h | 2436 ++++++++
> .../isp/isp_7x/camsys/mtk_cam-plat-util.c | 207 +
> .../isp/isp_7x/camsys/mtk_cam-plat-util.h | 16 +
> .../mediatek/isp/isp_7x/camsys/mtk_cam-pool.c | 393 ++
> .../mediatek/isp/isp_7x/camsys/mtk_cam-pool.h | 28 +
> .../mediatek/isp/isp_7x/camsys/mtk_cam-raw.c | 5359 +++++++++++++++++
> .../mediatek/isp/isp_7x/camsys/mtk_cam-raw.h | 325 +
> .../isp/isp_7x/camsys/mtk_cam-raw_debug.c | 403 ++
> .../isp/isp_7x/camsys/mtk_cam-raw_debug.h | 39 +
> .../isp/isp_7x/camsys/mtk_cam-regs-mt8188.h | 382 ++
> .../isp/isp_7x/camsys/mtk_cam-seninf-def.h | 193 +
> .../isp/isp_7x/camsys/mtk_cam-seninf-drv.c | 1741 ++++++
> .../isp/isp_7x/camsys/mtk_cam-seninf-drv.h | 16 +
> .../isp/isp_7x/camsys/mtk_cam-seninf-hw.h | 120 +
> .../isp/isp_7x/camsys/mtk_cam-seninf-if.h | 28 +
> .../isp/isp_7x/camsys/mtk_cam-seninf-regs.h | 40 +
> .../isp/isp_7x/camsys/mtk_cam-seninf-route.c | 356 ++
> .../isp/isp_7x/camsys/mtk_cam-seninf-route.h | 23 +
> .../isp/isp_7x/camsys/mtk_cam-seninf.h | 170 +
> .../isp/isp_7x/camsys/mtk_cam-timesync.c | 125 +
> .../isp/isp_7x/camsys/mtk_cam-timesync.h | 12 +
> .../isp/isp_7x/camsys/mtk_cam-ufbc-def.h | 59 +
> .../isp/isp_7x/camsys/mtk_cam-video.c | 1817 ++++++
> .../isp/isp_7x/camsys/mtk_cam-video.h | 224 +
> .../mediatek/isp/isp_7x/camsys/mtk_cam.c | 4168 +++++++++++++
> .../mediatek/isp/isp_7x/camsys/mtk_cam.h | 733 +++
> .../isp_7x/camsys/mtk_camera-v4l2-controls.h | 65 +
> .../isp_7x/camsys/mtk_csi_phy_2_0/Makefile | 5 +
> .../mtk_csi_phy_2_0/mtk_cam-seninf-cammux.h | 911 +++
> .../mtk_cam-seninf-csi0-cphy.h | 69 +
> .../mtk_cam-seninf-csi0-dphy.h | 139 +
> .../mtk_cam-seninf-hw_phy_2_0.c | 2879 +++++++++
> .../mtk_cam-seninf-mipi-rx-ana-cdphy-csi0a.h | 257 +
> .../mtk_cam-seninf-seninf1-csi2.h | 415 ++
> .../mtk_cam-seninf-seninf1-mux.h | 147 +
> .../mtk_csi_phy_2_0/mtk_cam-seninf-seninf1.h | 47 +
> .../mtk_csi_phy_2_0/mtk_cam-seninf-tg1.h | 49 +
> .../mtk_csi_phy_2_0/mtk_cam-seninf-top-ctrl.h | 99 +
> include/uapi/linux/mtkisp_camsys.h | 227 +
> 60 files changed, 30194 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek/mediatek,cam-raw.yaml
> create mode 100644 Documentation/devicetree/bindings/media/mediatek/mediatek,cam-yuv.yaml
> create mode 100644 Documentation/devicetree/bindings/media/mediatek/mediatek,camisp.yaml
> create mode 100644 Documentation/devicetree/bindings/media/mediatek/mediatek,seninf-core.yaml
> create mode 100644 Documentation/devicetree/bindings/media/mediatek/mediatek,seninf.yaml
> create mode 100644 drivers/media/platform/mediatek/isp/Kconfig
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/Makefile
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/Makefile
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/kd_imgsensor_define_v4l2.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-ctrl.c
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-ctrl.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-debug.c
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-debug.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-defs.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-dmadbg.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-feature.c
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-feature.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-fmt.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-ipi.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-meta-mt8188.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-plat-util.c
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-plat-util.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-pool.c
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-pool.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-raw.c
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-raw.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-raw_debug.c
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-raw_debug.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-regs-mt8188.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-seninf-def.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-seninf-drv.c
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-seninf-drv.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-seninf-hw.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-seninf-if.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-seninf-regs.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-seninf-route.c
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-seninf-route.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-seninf.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-timesync.c
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-timesync.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-ufbc-def.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-video.c
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam-video.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam.c
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_camera-v4l2-controls.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_csi_phy_2_0/Makefile
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_csi_phy_2_0/mtk_cam-seninf-cammux.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_csi_phy_2_0/mtk_cam-seninf-csi0-cphy.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_csi_phy_2_0/mtk_cam-seninf-csi0-dphy.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_csi_phy_2_0/mtk_cam-seninf-hw_phy_2_0.c
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_csi_phy_2_0/mtk_cam-seninf-mipi-rx-ana-cdphy-csi0a.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_csi_phy_2_0/mtk_cam-seninf-seninf1-csi2.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_csi_phy_2_0/mtk_cam-seninf-seninf1-mux.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_csi_phy_2_0/mtk_cam-seninf-seninf1.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_csi_phy_2_0/mtk_cam-seninf-tg1.h
> create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_csi_phy_2_0/mtk_cam-seninf-top-ctrl.h
> create mode 100644 include/uapi/linux/mtkisp_camsys.h
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists