linux-kernel - Re: [PATCH 4/5] drm/connector: make mode_valid_ctx accept const struct drm_display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mshw4ztn.fsf@intel.com>
Date: Mon, 18 Nov 2024 12:10:44 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, Rodrigo Vivi
 <rodrigo.vivi@...el.com>, Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin <tursulin@...ulin.net>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Maarten
 Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Karol
 Herbst <kherbst@...hat.com>, Lyude Paul <lyude@...hat.com>, Danilo
 Krummrich <dakr@...hat.com>, Harry Wentland <harry.wentland@....com>, Leo
 Li <sunpeng.li@....com>, Rodrigo Siqueira <Rodrigo.Siqueira@....com>, Alex
 Deucher <alexander.deucher@....com>, Christian König
 <christian.koenig@....com>, Xinhui Pan <Xinhui.Pan@....com>, Alain Volmat
 <alain.volmat@...s.st.com>, Raphael Gallais-Pou <rgallaispou@...il.com>,
 Liviu Dudau <liviu.dudau@....com>, Andrzej Hajda
 <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>,
 Robert Foss <rfoss@...nel.org>, Laurent Pinchart
 <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Peter Senna Tschudin
 <peter.senna@...il.com>, Ian Ray <ian.ray@...com>, Martyn Welch
 <martyn.welch@...labora.co.uk>, Inki Dae <inki.dae@...sung.com>, Seung-Woo
 Kim <sw0312.kim@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com>,
 Krzysztof Kozlowski <krzk@...nel.org>, Alim Akhtar
 <alim.akhtar@...sung.com>, Stefan Agner <stefan@...er.ch>, Alison Wang
 <alison.wang@....com>, Patrik Jakobsson <patrik.r.jakobsson@...il.com>,
 Philipp Zabel <p.zabel@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
 <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Rob Clark
 <robdclark@...il.com>, Abhinav Kumar <quic_abhinavk@...cinc.com>, Sean
 Paul <sean@...rly.run>, Marijn Suijten <marijn.suijten@...ainline.org>,
 Dave Airlie <airlied@...hat.com>, Gerd Hoffmann <kraxel@...hat.com>, Sandy
 Huang <hjc@...k-chips.com>, Heiko Stübner
 <heiko@...ech.de>, Andy Yan
 <andy.yan@...k-chips.com>, Chen-Yu Tsai <wens@...e.org>, Samuel Holland
 <samuel@...lland.org>, Thierry Reding <thierry.reding@...il.com>, Mikko
 Perttunen <mperttunen@...dia.com>, Jonathan Hunter <jonathanh@...dia.com>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>, Maíra
 Canal
 <mcanal@...lia.com>, Raspberry Pi Kernel Maintenance
 <kernel-list@...pberrypi.com>, Gurchetan Singh
 <gurchetansingh@...omium.org>, Chia-I Wu <olvaffe@...il.com>, Zack Rusin
 <zack.rusin@...adcom.com>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>
Cc: intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 nouveau@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-msm@...r.kernel.org,
 freedreno@...ts.freedesktop.org, virtualization@...ts.linux.dev,
 spice-devel@...ts.freedesktop.org, linux-rockchip@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org
Subject: Re: [PATCH 4/5] drm/connector: make mode_valid_ctx accept const
 struct drm_display_mode

On Fri, 15 Nov 2024, Dmitry Baryshkov <dmitry.baryshkov@...aro.org> wrote:
> The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge
> accept const struct drm_display_mode argument. Change the mode_valid_ctx
> callback of drm_connector to also accept const argument.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

Acked-by: Jani Nikula <jani.nikula@...el.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
>  include/drm/drm_modeset_helper_vtables.h    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index 7be8fb047b6c17cb37b9021a2dbf430f0aaecfa2..cfefd89209ca864e19771c538ca00016f9322e74 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -1432,7 +1432,7 @@ static int intel_dp_mst_get_modes(struct drm_connector *connector)
>  
>  static int
>  intel_dp_mst_mode_valid_ctx(struct drm_connector *connector,
> -			    struct drm_display_mode *mode,
> +			    const struct drm_display_mode *mode,
>  			    struct drm_modeset_acquire_ctx *ctx,
>  			    enum drm_mode_status *status)
>  {
> diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h
> index ec59015aec3cf3ba01510031c55df8c0b3e0b382..fa9ee6a128bec0205f501df6f7634757f5fcb9ee 100644
> --- a/include/drm/drm_modeset_helper_vtables.h
> +++ b/include/drm/drm_modeset_helper_vtables.h
> @@ -1006,7 +1006,7 @@ struct drm_connector_helper_funcs {
>  	 *
>  	 */
>  	int (*mode_valid_ctx)(struct drm_connector *connector,
> -			      struct drm_display_mode *mode,
> +			      const struct drm_display_mode *mode,
>  			      struct drm_modeset_acquire_ctx *ctx,
>  			      enum drm_mode_status *status);

-- 
Jani Nikula, Intel