linux-kernel - Re: [PATCH 04/15] coresight: etm4x: don't include 'pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea311a21-959d-4985-9364-7c85d256ab09@arm.com>
Date: Mon, 18 Nov 2024 10:34:41 +0000
From: Suzuki K Poulose <suzuki.poulose@....com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
 linux-kernel@...r.kernel.org
Cc: Mike Leach <mike.leach@...aro.org>, James Clark <james.clark@...aro.org>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 04/15] coresight: etm4x: don't include 'pm_wakeup.h'
 directly

On 18/11/2024 07:29, Wolfram Sang wrote:
> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>   drivers/hwtracing/coresight/coresight-etm4x-core.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> index 66d44a404ad0..559972a00fdf 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> @@ -23,7 +23,6 @@
>   #include <linux/cpu_pm.h>
>   #include <linux/coresight.h>
>   #include <linux/coresight-pmu.h>
> -#include <linux/pm_wakeup.h>
>   #include <linux/amba/bus.h>
>   #include <linux/seq_file.h>
>   #include <linux/uaccess.h>

If you plan to take this as a collection outside of CoreSight tree,

Acked-by: Suzuki K Poulose <suzuki.poulose@....com>

Otherwise, I can pick this up.


Suzuki