linux-kernel - Re: [RFC PATCH nand/next 1/4] mtd: nand: Create param.c to do CRC check and bitwise majority for Parameter & CASN page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bjyczu8k.fsf@bootlin.com>
Date: Mon, 18 Nov 2024 11:55:39 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Sky Huang <SkyLake.Huang@...iatek.com>
Cc: Matthias Brugger <matthias.bgg@...il.com>,  AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>,  Richard Weinberger
 <richard@....at>,  Vignesh Raghavendra <vigneshr@...com>,  Daniel Golle
 <daniel@...rotopia.org>,  Chia-Lin Kao <acelan.kao@...onical.com>,  "Mika
 Westerberg" <mika.westerberg@...ux.intel.com>,  Cheng Ming Lin
 <chengminglin@...c.com.tw>,  <linux-kernel@...r.kernel.org>,
  <linux-mtd@...ts.infradead.org>,  <linux-arm-kernel@...ts.infradead.org>,
  <linux-mediatek@...ts.infradead.org>,  Steven Liu
 <Steven.Liu@...iatek.com>
Subject: Re: [RFC PATCH nand/next 1/4] mtd: nand: Create param.c to do CRC
 check and bitwise majority for Parameter & CASN page

On 20/10/2024 at 21:27:19 +08, Sky Huang <SkyLake.Huang@...iatek.com> wrote:

> From: "Sky.Huang" <skylake.huang@...iatek.com>
>
> Create drivers/mtd/nand/param.c so ONFI parameter page & CASN page
> can both use nanddev_crc16() and nanddev_bit_wise_majority() directly
> like this:
> * For ONFI Parameter page:
> onfi_crc16() -> nanddev_crc16()
> * For CASN page: nanddev_crc16()
>
> nanddev_bit_wise_majority() is same as nand_bit_wise_majority().

Please use the same nanddev_ prefix.

> nanddev_crc16() is same as onfi_crc16(). But there are lots of
> onfi_crc16() call, so keep onfi_crc16() there and hook it to
> nanddev_crc16().
>
> Signed-off-by: Sky Huang <skylake.huang@...iatek.com>

Thanks,
Miquèl