linux-kernel - Re: [External] Re: [PATCH] fuse: check attributes staleness on fuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegvxU2kd3Ux1PVei+PcRyy3Qum9MOrd_-pqbwL=aWD1e7w@mail.gmail.com>
Date: Mon, 18 Nov 2024 12:27:13 +0100
From: Miklos Szeredi <miklos@...redi.hu>
To: Zhang Tianci <zhangtianci.1997@...edance.com>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	xieyongji@...edance.com, Jiachen Zhang <zhangjiachen.jaycee@...edance.com>
Subject: Re: [External] Re: [PATCH] fuse: check attributes staleness on fuse_iget()

On Mon, 18 Nov 2024 at 11:15, Zhang Tianci
<zhangtianci.1997@...edance.com> wrote:

> > +       if (!evict_ctr || fi->attr_version || evict_ctr == fuse_get_evict_ctr(fc))
> > +               set_mask_bits(&fi->inval_mask, STATX_BASIC_STATS, 0);
>
> This check should be moved to before the initialization of fi->attr_version.

Well spotted.

> >         inode->i_ino     = fuse_squash_ino(attr->ino);
> >         inode->i_mode    = (inode->i_mode & S_IFMT) | (attr->mode & 07777);
>
> And I will send out the v2 patch later.

Thanks, applied and pushed.

Miklos