linux-kernel - Re: [PATCH v2 1/4] parport: use standard kernel printing functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZzszI9obKws73vgL@ryzen>
Date: Mon, 18 Nov 2024 13:29:23 +0100
From: Niklas Cassel <cassel@...nel.org>
To: 412574090@....com
Cc: dlemoal@...nel.org, James.Bottomley@...senpartnership.com,
	andreas@...sler.com, andrew+netdev@...n.ch, davem@...emloft.net,
	deller@....de, edumazet@...gle.com, linux-kernel@...r.kernel.org,
	martin.petersen@...cle.co, mpe@...erman.id.au, ojeda@...nel.org,
	perex@...ex.cz, sudipm.mukherjee@...il.com, t.sailer@...mni.ethz.ch,
	weiyufeng@...inos.cn, xiongxin@...inos.cn
Subject: Re: [PATCH v2 1/4] parport: use standard kernel printing functions

Hello weiyufeng,

On Mon, Nov 18, 2024 at 10:30:24AM +0800, 412574090@....com wrote:
> > On 11/12/24 11:11, 412574090@....com wrote:
> > > From: weiyufeng <weiyufeng@...inos.cn>
> > > 
> > > change printk to standard kernel printing functions.
> > > 
> > > Signed-off-by: weiyufeng <weiyufeng@...inos.cn>
> > > ---
> > >  drivers/net/hamradio/baycom_epp.c |  8 ++++----
> > >  drivers/net/hamradio/baycom_par.c |  6 +++---
> > >  drivers/parport/parport_pc.c      | 12 ++++++------
> > >  drivers/parport/procfs.c          |  2 +-
> >
> > This is mixing changes for different drivers. Please split the net and ata part
> > into different patches and send the net ones to the correct list and maintainers.
> Yes, it will be updated in v3 version. Can you help review the patch for
> path2-patch4? If possible, it would be a great honor.

Sorry, that is not how it works.

If I look at patch 2/4, it changes all these files:
 drivers/ata/pata_parport/bpck6.c        |  2 +-
 drivers/ata/pata_parport/pata_parport.c |  2 +-
 drivers/auxdisplay/ks0108.c             |  4 +--
 drivers/net/hamradio/baycom_epp.c       | 10 +++---
 drivers/net/hamradio/baycom_par.c       |  6 ++--
 drivers/net/plip/plip.c                 |  2 +-
 drivers/parport/daisy.c                 |  2 +-
 drivers/parport/parport_gsc.c           |  8 ++---
 drivers/parport/parport_ip32.c          |  8 ++---
 drivers/parport/parport_mfc3.c          |  2 +-
 drivers/parport/parport_pc.c            | 42 ++++++++++++-------------
 drivers/parport/parport_sunbpp.c        | 24 +++++++-------
 drivers/parport/procfs.c                |  2 +-
 drivers/parport/share.c                 |  6 ++--
 drivers/scsi/imm.c                      |  8 ++---
 drivers/scsi/ppa.c                      | 10 +++---
 include/linux/parport.h                 |  4 +--
 include/linux/parport_pc.h              | 18 +++++------
 sound/drivers/mts64.c                   |  6 ++--
 sound/drivers/portman2x4.c              |  6 ++--

So we cannot give your Reviewed-by tag to this commit.

So please split the commit to the appropriate subsystems,
and CC: the proper mailing lists for each commit.
(Check the MAINTAINERS file.)

Then people will be able to review your changes.


Kind regards,
Niklas