linux-kernel - Re: [PATCH v2] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <801c3154-07a8-40ff-af68-b5dac8c83e9a@ti.com>
Date: Mon, 18 Nov 2024 08:10:32 -0600
From: Andrew Davis <afd@...com>
To: Nobuhiro Iwamatsu <iwamatsu@...auri.org>,
        Sebastian Reichel
	<sre@...nel.org>,
        Laxman Dewangan <ldewangan@...dia.com>
CC: <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] power: reset: as3722-poweroff: Remove unnecessary
 return in as3722_poweroff_probe

On 11/16/24 11:34 PM, Nobuhiro Iwamatsu wrote:
> The return is executed on the devm_register_sys_off_handler() line in
> as3722_poweroff_probe, so the last return line is unnecessary. Remove it.
> 
> Fixes: 348fde771ce7 ("power: reset: as3722-poweroff: Use devm_register_sys_off_handler(POWER_OFF)")
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@...auri.org>
> ---

Acked-by: Andrew Davis <afd@...com>

>   v2: Set correct mail address for Sebastian Reichel.
> 
>   drivers/power/reset/as3722-poweroff.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/power/reset/as3722-poweroff.c b/drivers/power/reset/as3722-poweroff.c
> index bb26fa6fa67ca7..8075382cbc3625 100644
> --- a/drivers/power/reset/as3722-poweroff.c
> +++ b/drivers/power/reset/as3722-poweroff.c
> @@ -57,8 +57,6 @@ static int as3722_poweroff_probe(struct platform_device *pdev)
>   					     SYS_OFF_PRIO_DEFAULT,
>   					     as3722_pm_power_off,
>   					     as3722_poweroff);
> -
> -	return 0;
>   }
>   
>   static struct platform_driver as3722_poweroff_driver = {