linux-kernel - Re: [PATCH] ceph: Use str_true_false() helper in status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOi1vP_3JmofvsFiCiF0xvz7aS4Z5o9MEW6=bWEwuxtAc_sPmw@mail.gmail.com>
Date: Mon, 18 Nov 2024 15:19:25 +0100
From: Ilya Dryomov <idryomov@...il.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Xiubo Li <xiubli@...hat.com>, ceph-devel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ceph: Use str_true_false() helper in status_show()

On Tue, Nov 12, 2024 at 10:16 PM Thorsten Blum <thorsten.blum@...ux.dev> wrote:
>
> Remove hard-coded strings by using the str_true_false() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  fs/ceph/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index 24c08078f5aa..fdf9dc15eafa 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -357,7 +357,7 @@ static int status_show(struct seq_file *s, void *p)
>
>         seq_printf(s, "instance: %s.%lld %s/%u\n", ENTITY_NAME(inst->name),
>                    ceph_pr_addr(client_addr), le32_to_cpu(client_addr->nonce));
> -       seq_printf(s, "blocklisted: %s\n", fsc->blocklisted ? "true" : "false");
> +       seq_printf(s, "blocklisted: %s\n", str_true_false(fsc->blocklisted));
>
>         return 0;
>  }
> --
> 2.47.0
>

Applied.

Thanks,

                Ilya