linux-kernel - Re: [PATCH net-next] net: phy: qt2025: simplify Result<()> in probe return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f3b1fc2-70b1-4ffe-b41c-09b52ce21277@lunn.ch>
Date: Mon, 18 Nov 2024 15:15:22 +0100
From: Andrew Lunn <andrew@...n.ch>
To: manas18244@...td.ac.in
Cc: FUJITA Tomonori <fujita.tomonori@...il.com>,
	Trevor Gross <tmgross@...ch.edu>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <skhan@...uxfoundation.org>,
	Anup Sharma <anupnewsmail@...il.com>, netdev@...r.kernel.org,
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: qt2025: simplify Result<()> in probe
 return

On Mon, Nov 18, 2024 at 06:39:34PM +0530, Manas via B4 Relay wrote:
> From: Manas <manas18244@...td.ac.in>
> 
> probe returns a `Result<()>` type, which can be simplified as `Result`,
> due to default type parameters being unit `()` and `Error` types. This
> maintains a consistent usage of `Result` throughout codebase.
> 
> Signed-off-by: Manas <manas18244@...td.ac.in>

Miguel has already pointed out, this is probably not sufficient for a
signed-off-by: You need a real name here, in order to keep the lawyers happy.

Also, each subsystem has its own way of doing things. Please take a
read of:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

    Andrew

---
pw-bot: cr