linux-kernel - Re: [PATCH] sched/task_stack: Fix object_is_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfc6291c4fadd5b7720945e6242a2f59f8f2dae3.camel@mediatek.com>
Date: Mon, 18 Nov 2024 03:12:59 +0000
From: Qun-wei Lin (林群崴) <Qun-wei.Lin@...iatek.com>
To: "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
CC: Andrew Yang (楊智強) <Andrew.Yang@...iatek.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	Elena Yu (余季芸) <Elena.Yu@...iatek.com>,
	"pasha.tatashin@...een.com" <pasha.tatashin@...een.com>,
	"shakeel.butt@...ux.dev" <shakeel.butt@...ux.dev>, wsd_upstream
	<wsd_upstream@...iatek.com>, Chinwen Chang (張錦文)
	<chinwen.chang@...iatek.com>, Casper Li (李中榮)
	<casper.li@...iatek.com>, "catalin.marinas@....com"
	<catalin.marinas@....com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "kent.overstreet@...ux.dev"
	<kent.overstreet@...ux.dev>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH] sched/task_stack: Fix object_is_on_stack() for KASAN
 tagged pointers

On Tue, 2024-11-12 at 23:06 -0800, Andrew Morton wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Wed, 13 Nov 2024 12:25:43 +0800 Qun-Wei Lin <
> qun-wei.lin@...iatek.com> wrote:
> 
> > When CONFIG_KASAN_SW_TAGS and CONFIG_KASAN_STACK are enabled, the
> > object_is_on_stack() function may produce incorrect results due to
> > the
> > presence of tags in the obj pointer, while the stack pointer does
> > not
> > have tags. This discrepancy can lead to incorrect stack object
> > detection
> > and subsequently trigger warnings if CONFIG_DEBUG_OBJECTS is also
> > enabled.
> > 
> > Example of the warning:
> 
> Thanks.
> 
> Are we able to identify when this started happening?  ie, a suitable
> Fixes: taret?
> 

The issue has been present since the introduction of
CONFIG_KASAN_STACK. The stack instrumentation was not accounted for in
the object_is_on_stack() function from the beginning.

Thanks!