linux-kernel - Re: [PATCH 1/3] perf: arm-ni: Remove spurious NULL in attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e04fa8f-7c08-49a9-9647-f8d1f183ffcf@arm.com>
Date: Mon, 18 Nov 2024 15:23:47 +0000
From: Robin Murphy <robin.murphy@....com>
To: Thomas Weißschuh <linux@...ssschuh.net>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Will Deacon <will@...nel.org>,
 Mark Rutland <mark.rutland@....com>, Heiko Carstens <hca@...ux.ibm.com>,
 Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev
 <agordeev@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>,
 Sven Schnelle <svens@...ux.ibm.com>, Thomas Gleixner <tglx@...utronix.de>,
 Peter Zijlstra <peterz@...radead.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-s390@...r.kernel.org
Subject: Re: [PATCH 1/3] perf: arm-ni: Remove spurious NULL in attribute_group
 definition

On 2024-11-18 3:02 pm, Thomas Weißschuh wrote:
> This NULL value is most-likely a copy-paste error from an array
> definition. So far the NULL didn't have any effect.
> As there will be a union in struct attribute_group at this location,
> it will trigger a compiler warning.

Acked-by: Robin Murphy <robin.murphy@....com>

> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
>   drivers/perf/arm-ni.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/perf/arm-ni.c b/drivers/perf/arm-ni.c
> index 90fcfe693439ef3e18e23c6351433ac3c5ea78b5..fd7a5e60e96302fada29cd44e7bf9c582e93e4ce 100644
> --- a/drivers/perf/arm-ni.c
> +++ b/drivers/perf/arm-ni.c
> @@ -247,7 +247,6 @@ static struct attribute *arm_ni_other_attrs[] = {
>   
>   static const struct attribute_group arm_ni_other_attr_group = {
>   	.attrs = arm_ni_other_attrs,
> -	NULL
>   };
>   
>   static const struct attribute_group *arm_ni_attr_groups[] = {
>