linux-kernel - Re: [PATCH-next] afs: Remove logically dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <883923.1731943099@warthog.procyon.org.uk>
Date: Mon, 18 Nov 2024 15:18:19 +0000
From: David Howells <dhowells@...hat.com>
To: Advait Dhamorikar <advaitdhamorikar@...il.com>
Cc: dhowells@...hat.com, Marc Dionne <marc.dionne@...istor.com>,
    linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH-next] afs: Remove logically dead code

Advait Dhamorikar <advaitdhamorikar@...il.com> wrote:

>  	iterate_folioq(&iter, iov_iter_count(&iter), dvnode, ctx,
>  		       afs_dir_iterate_step);
>  
> -	if (ret == -ESTALE)
> -		afs_invalidate_dir(dvnode, afs_dir_invalid_iter_stale);
>  	return ret;

Removing this is the wrong thing to do.  However, you're correct that ret is
never set to -ESTALE.

A better solution, I think, is to check the result of iterate_folioq(),
invalidating the dir and returning -ESTALE if 0 and if the iterator count is
not 0.

David