linux-kernel - Re: [PATCH] drm/radeon: Constify struct pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_NLObja=ctv60w3uhx1yf-bZTUhR2VvtT=aUkaG4SXOUg@mail.gmail.com>
Date: Mon, 18 Nov 2024 10:26:18 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Christian König <christian.koenig@....com>
Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>, linux@...ssschuh.net, broonie@...nel.org, 
	lee@...nel.org, Alex Deucher <alexander.deucher@....com>, Xinhui Pan <Xinhui.Pan@....com>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/radeon: Constify struct pci_device_id

Applied.  Thanks!

Alex

On Mon, Nov 18, 2024 at 6:25 AM Christian König
<christian.koenig@....com> wrote:
>
> Am 15.11.24 um 18:26 schrieb Christophe JAILLET:
> > 'struct pci_device_id' is not modified in this driver.
> >
> > Constifying this structure moves some data to a read-only section, so
> > increase overall security.
> >
> > On a x86_64, with allmodconfig:
> > Before:
> > ======
> >     text         data     bss     dec     hex filename
> >    11984        28672      44   40700    9efc drivers/gpu/drm/radeon/radeon_drv.o
> >
> > After:
> > =====
> >     text         data     bss     dec     hex filename
> >    40000          664      44   40708    9f04 drivers/gpu/drm/radeon/radeon_drv.o
>
> Mhm that's a bit more than "some data" :)
>
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
>
> Acked-by: Christian König <christian.koenig@....com>
>
> > ---
> > Compile tested-only.
> > ---
> >   drivers/gpu/drm/radeon/radeon_drv.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> > index 23d6d1a2586d..5e958cc223f4 100644
> > --- a/drivers/gpu/drm/radeon/radeon_drv.c
> > +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> > @@ -248,10 +248,9 @@ int radeon_cik_support = 1;
> >   MODULE_PARM_DESC(cik_support, "CIK support (1 = enabled (default), 0 = disabled)");
> >   module_param_named(cik_support, radeon_cik_support, int, 0444);
> >
> > -static struct pci_device_id pciidlist[] = {
> > +static const struct pci_device_id pciidlist[] = {
> >       radeon_PCI_IDS
> >   };
> > -
> >   MODULE_DEVICE_TABLE(pci, pciidlist);
> >
> >   static const struct drm_driver kms_driver;
>