linux-kernel - Re: [PATCH v6 07/15] digest_cache: Allow registration of digest list parsers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6a7b5eb-d2ec-45e5-8a9b-a91f9c0cec78@infradead.org>
Date: Tue, 19 Nov 2024 08:46:35 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Roberto Sassu <roberto.sassu@...weicloud.com>, zohar@...ux.ibm.com,
 dmitry.kasatkin@...il.com, eric.snowberg@...cle.com, corbet@....net,
 mcgrof@...nel.org, petr.pavlu@...e.com, samitolvanen@...gle.com,
 da.gomez@...sung.com, akpm@...ux-foundation.org, paul@...l-moore.com,
 jmorris@...ei.org, serge@...lyn.com, shuah@...nel.org,
 mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com
Cc: linux-integrity@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
 linux-modules@...r.kernel.org, linux-security-module@...r.kernel.org,
 linux-kselftest@...r.kernel.org, wufan@...ux.microsoft.com,
 pbrobinson@...il.com, zbyszek@...waw.pl, hch@....de, mjg59@...f.ucam.org,
 pmatilai@...hat.com, jannh@...gle.com, dhowells@...hat.com,
 jikos@...nel.org, mkoutny@...e.com, ppavlu@...e.com, petr.vorel@...il.com,
 mzerqung@...inter.de, kgold@...ux.ibm.com,
 Roberto Sassu <roberto.sassu@...wei.com>
Subject: Re: [PATCH v6 07/15] digest_cache: Allow registration of digest list
 parsers

Hi--

On 11/19/24 2:49 AM, Roberto Sassu wrote:
> +/**
> + * struct parser - Structure to store a function pointer to parse digest list
> + * @list: Linked list
> + * @owner: Kernel module owning the parser
> + * @name: Parser name (must match the format in the digest list file name)
> + * @func: Function pointer for parsing
> + *
> + * This structure stores a function pointer to parse a digest list.
> + */
> +struct parser {
> +	struct list_head list;
> +	struct module *owner;
> +	const char name[NAME_MAX + 1];
> +	parser_func func;
> +};

I would make the struct name not so generic -- maybe digest_parser ...

thanks.
-- 
~Randy