linux-kernel - Re: [PATCH v6 01/15] lib: Add TLV parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8b1fb69-ac58-47a5-a2df-26a88894a6ea@infradead.org>
Date: Tue, 19 Nov 2024 08:51:57 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Roberto Sassu <roberto.sassu@...weicloud.com>, zohar@...ux.ibm.com,
 dmitry.kasatkin@...il.com, eric.snowberg@...cle.com, corbet@....net,
 mcgrof@...nel.org, petr.pavlu@...e.com, samitolvanen@...gle.com,
 da.gomez@...sung.com, akpm@...ux-foundation.org, paul@...l-moore.com,
 jmorris@...ei.org, serge@...lyn.com, shuah@...nel.org,
 mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com
Cc: linux-integrity@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
 linux-modules@...r.kernel.org, linux-security-module@...r.kernel.org,
 linux-kselftest@...r.kernel.org, wufan@...ux.microsoft.com,
 pbrobinson@...il.com, zbyszek@...waw.pl, hch@....de, mjg59@...f.ucam.org,
 pmatilai@...hat.com, jannh@...gle.com, dhowells@...hat.com,
 jikos@...nel.org, mkoutny@...e.com, ppavlu@...e.com, petr.vorel@...il.com,
 mzerqung@...inter.de, kgold@...ux.ibm.com,
 Roberto Sassu <roberto.sassu@...wei.com>
Subject: Re: [PATCH v6 01/15] lib: Add TLV parser

Hi--

On 11/19/24 2:49 AM, Roberto Sassu wrote:
> +/**
> + * typedef callback - Callback after parsing TLV entry

Same as my other naming comment -- too generic.
Maybe tlv_callback...

Thanks.

> + * @callback_data: Opaque data to supply to the callback function
> + * @field: Field identifier
> + * @field_data: Field data
> + * @field_len: Length of @field_data
> + *
> + * This callback is invoked after a TLV entry is parsed.
> + *
> + * Return: Zero on success, a negative value on error.
> + */
> +typedef int (*callback)(void *callback_data, __u16 field,
> +			const __u8 *field_data, __u32 field_len);

-- 
~Randy