[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241119171315.GA1805024-robh@kernel.org>
Date: Tue, 19 Nov 2024 11:13:15 -0600
From: Rob Herring <robh@...nel.org>
To: Konrad Dybcio <konradybcio@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Wesley Cheng <quic_wcheng@...cinc.com>,
Marijn Suijten <marijn.suijten@...ainline.org>,
linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH] dt-bindings: usb: qcom,dwc3: Make ss_phy_irq optional
for X1E80100
On Sat, Nov 16, 2024 at 12:17:52PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>
> X1 has multiple DWC3 hosts, including one that's USB2, which naturally
> means it doesn't have a SuperSpeed interrupt. Make it optional to fix
> warnings such as:
>
> usb@...8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
That's a good start, but what about all the other warnings for usb
interrupts?:
13 usb@...f8800: 'interrupt-names' is a required property
11 usb@...8800: interrupt-names: ['pwr_event', 'qusb2_phy', 'hs_phy_irq'] is too short
11 usb@...8800: interrupts: [[0, 347, 4], [0, 243, 4]] is too short
11 usb@...8800: interrupt-names:1: 'qusb2_phy' was expected
11 usb@...8800: interrupt-names:0: 'pwr_event' was expected
11 usb@...8800: interrupt-names: ['hs_phy_irq', 'ss_phy_irq'] is too short
9 usb@...8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
7 usb@...8800: interrupt-names: ['pwr_event', 'qusb2_phy', 'hs_phy_irq'] is too short
5 usb@...8800: interrupts-extended: [[1, 0, 134, 4]] is too short
5 usb@...8800: interrupt-names: ['pwr_event'] is too short
4 usb@...8800: interrupts: [[0, 62, 4]] is too short
4 usb@...8800: interrupt-names: ['hs_phy_irq'] is too short
> Signed-off-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
Powered by blists - more mailing lists