linux-kernel - Re: [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jqidbstpdrn7k7w55rwkg6e243d7r373qfjvz2ujzstcr5oda5@v2vxvsithtb5>
Date: Tue, 19 Nov 2024 20:51:17 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Liam Zuiderhoek <zuiderhoekl@...il.com>
Cc: wsa+renesas@...g-engineering.com, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue

Hi Liam,

your patch is almost correct, just a few things need to be fixed.

On Thu, Nov 14, 2024 at 05:50:06PM +0100, Liam Zuiderhoek wrote:
> From 214adebf7cf37be941f208124fac9ea6bec0f1d2 Mon Sep 17 00:00:00 2001
> From: Liam Zuiderhoek <zuiderhoekl@...il.com>
> Date: Tue, 22 Oct 2024 20:46:59 +0200
> Subject: [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue

Why the header file is in the commit log?

The title needs to be written in imperative form:

  "Fix whitespace style issue"

instead of

  "fixed a whitespace..."

> Fixing a coding style issue.

We have plenty of space in the commit log and you can be more
specific on the coding style you are fixing; e.g. "use tabs
instead of white spaces for alignment".

Please read Documentation/process/submitting-patches.rst.

> Signed-off-by: Liam Zuiderhoek <zuiderhoekl@...il.com>
> ---
>  drivers/i2c/i2c-core-smbus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-smbus.c
> index e3b96fc53b5c..6829def15933 100644
> --- a/drivers/i2c/i2c-core-smbus.c
> +++ b/drivers/i2c/i2c-core-smbus.c
> @@ -122,7 +122,7 @@ EXPORT_SYMBOL(i2c_smbus_read_byte);
>  s32 i2c_smbus_write_byte(const struct i2c_client *client, u8 value)
>  {
>  	return i2c_smbus_xfer(client->adapter, client->addr, client->flags,
> -	                      I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL);
> +				I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL);

Please align everything under the "(":

	return i2c_smbus_xfer(client->adapter, client->addr, client->flags,
			      I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL);

That means, use as many tabs as you can, until you need to use
spaces to align under the "(".

Thanks,
Andi