linux-kernel - Re: [PATCH v3 2/4] riscv: export __cpuid_to_hartid_map

Open Source and information security mailing list archives

Message-ID: <CAOnJCU+ac07aT9jLf5zqB+HnzHyqLMZE-Mz+cJDTdMAkS6LRTg@mail.gmail.com>
Date: Tue, 19 Nov 2024 12:32:26 -0800
From: Atish Patra <atishp@...shpatra.org>
To: Rob Herring <robh@...nel.org>
Cc: Valentina Fernandez <valentina.fernandezalanis@...rochip.com>, paul.walmsley@...ive.com, 
	palmer@...belt.com, aou@...s.berkeley.edu, ycliang@...estech.com, 
	prabhakar.mahadev-lad.rj@...renesas.com, peterlin@...estech.com, 
	samuel.holland@...ive.com, conor.dooley@...rochip.com, alexghiti@...osinc.com, 
	ruanjinjie@...wei.com, takakura@...inux.co.jp, conor+dt@...nel.org, 
	jassisinghbrar@...il.com, krzk+dt@...nel.org, linux-riscv@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/4] riscv: export __cpuid_to_hartid_map

On Mon, Nov 11, 2024 at 1:52 PM Rob Herring <robh@...nel.org> wrote:
>
> On Tue, Nov 05, 2024 at 06:35:11PM +0000, Valentina Fernandez wrote:
> > EXPORT_SYMBOL_GPL() is missing for __cpuid_to_hartid_map array.
> > Export this symbol to allow drivers compiled as modules to use
> > cpuid_to_hartid_map().
> >
> > Signed-off-by: Valentina Fernandez <valentina.fernandezalanis@...rochip.com>
> > ---
> >  arch/riscv/kernel/smp.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c
> > index c180a647a30e..d58b5e751286 100644
> > --- a/arch/riscv/kernel/smp.c
> > +++ b/arch/riscv/kernel/smp.c
> > @@ -43,6 +43,7 @@ enum ipi_message_type {
> >  unsigned long __cpuid_to_hartid_map[NR_CPUS] __ro_after_init = {
> >       [0 ... NR_CPUS-1] = INVALID_HARTID
> >  };
> > +EXPORT_SYMBOL_GPL(__cpuid_to_hartid_map);
>
> Why can't riscv implement cpu_logical_map() like other arches?
>

We can and we should :)

> We really should have a common implementation too, but that's probably
> too much to ask I guess.
>
> Rob
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv


-- 
Regards,
Atish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives