linux-kernel - [PATCH v3] usb: dwc3: remove unused sg struct member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241119212452.269255-1-luis.hernandez093@gmail.com>
Date: Tue, 19 Nov 2024 16:24:51 -0500
From: Luis Felipe Hernandez <luis.hernandez093@...il.com>
To: Thinh.Nguyen@...opsys.com,
	gregkh@...uxfoundation.org,
	rbm@...e.com
Cc: Luis Felipe Hernandez <luis.hernandez093@...il.com>,
	skhan@...uxfoundation.org,
	linux-usb@...r.kernel.org,
	linux-kernel-mentees@...ts.linuxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH v3] usb: dwc3: remove unused sg struct member

The sg member of the dwc3_request struct is no longer used and should be
removed. This patch drops the unused member, cleaning up the struct.

Previously, this patch addressed a documentation warning caused by the
missing description for the sg member. However, upon review,
it was determined that the member itself is deprecated and can be removed
entirely.

This change improves code clarity and avoids maintaining unnecessary members
in the structure.

Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@...il.com>
Reported-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
Reviewed-by: Ricardo Marliere <rbm@...e.com>
---
v2: remove unused sg struct member as per review[1]
v3: 
  - Add reported-by tag as per review [2]
  - Carry over reviewed-by tag from v2 [3]
  - Update commit subject to reflect maintainers
  - Update commit message to reflect actual change gathered from 
    Thinh Nguyen's feedback

[1] https://lore.kernel.org/all/20241119020807.cn7ugxnhbkqwrr2b@synopsys.com/
[2] https://lore.kernel.org/all/2024111922-pantyhose-panorama-6f16@gregkh/
[3] https://lore.kernel.org/all/5l65sdskdzbehxamff5ax4ptiqhaxh7ewi4umtpp6ynen45nj6@nebuxjg4c4rx/
---
 drivers/usb/dwc3/core.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index ee73789326bc..3be069c4520e 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -956,7 +956,6 @@ struct dwc3_request {
 	struct usb_request	request;
 	struct list_head	list;
 	struct dwc3_ep		*dep;
-	struct scatterlist	*sg;
 	struct scatterlist	*start_sg;
 
 	unsigned int		num_pending_sgs;
-- 
2.47.0