linux-kernel - Re: [PATCH v4 14/19] fpga: dfl: store platform device id in feature device data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bf104bd76f115f53800df15ac1691884228bf51.camel@intel.com>
Date: Tue, 19 Nov 2024 23:34:38 +0000
From: "Colberg, Peter" <peter.colberg@...el.com>
To: "yilun.xu@...ux.intel.com" <yilun.xu@...ux.intel.com>
CC: "Xu, Yilun" <yilun.xu@...el.com>, "linux-fpga@...r.kernel.org"
	<linux-fpga@...r.kernel.org>, "mdf@...nel.org" <mdf@...nel.org>,
	"hao.wu@...el.com" <hao.wu@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "russ.weight@...ux.dev"
	<russ.weight@...ux.dev>, "Pagani, Marco" <marpagan@...hat.com>,
	"trix@...hat.com" <trix@...hat.com>,
	"basheer.ahmed.muddebihal@...ux.intel.com"
	<basheer.ahmed.muddebihal@...ux.intel.com>, "matthew.gerlach@...ux.intel.com"
	<matthew.gerlach@...ux.intel.com>
Subject: Re: [PATCH v4 14/19] fpga: dfl: store platform device id in feature
 device data

On Mon, 2024-11-18 at 22:34 +0800, Xu Yilun wrote:
> > @@ -1658,7 +1660,6 @@ void dfl_fpga_feature_devs_remove(struct dfl_fpga_cdev *cdev)
> >  
> > 
> > 
> > 
> >  		/* remove released ports */
> >  		if (!device_is_registered(&port_dev->dev)) {
> > -			dfl_id_free(fdata->type, port_dev->id);
> 
> Also remove the braces.

Thanks, this has been resolved in [PATCH v5 14/18].

Peter

> 
> Thanks,
> Yilun
> 
> >  			platform_device_put(port_dev);
> >  		}