linux-kernel - Re: [PATCH] virtio: remove the duplicate might

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1731983829.623387-1-xuanzhuo@linux.alibaba.com>
Date: Tue, 19 Nov 2024 10:37:09 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: "xiaowuding_jaguarmicro" <xiaowu.ding@...uarmicro.com>
Cc: eperezma@...hat.com,
 virtualization@...ts.linux.dev,
 linux-kernel@...r.kernel.org,
 angus.chen@...uarmicro.com,
 Xiaowu Ding <xiaowu.ding@...uarmicro.com>,
 mst@...hat.com,
 jasowang@...hat.com
Subject: Re: [PATCH] virtio: remove the duplicate might_sleep()

On Mon, 18 Nov 2024 20:40:56 +0800, "xiaowuding_jaguarmicro" <xiaowu.ding@...uarmicro.com> wrote:
> From: Xiaowu Ding <xiaowu.ding@...uarmicro.com>
>
> The virtio_add_status function have done might_sleep(),so we can remove
> the duplicate calls.


Is there any problem here? If not, I think we can keep it.

Thanks.

>
> Signed-off-by: Xiaowu Ding <xiaowu.ding@...uarmicro.com>
> ---
>  drivers/virtio/virtio.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
> index b9095751e..8352dfc1a 100644
> --- a/drivers/virtio/virtio.c
> +++ b/drivers/virtio/virtio.c
> @@ -205,8 +205,6 @@ static int virtio_features_ok(struct virtio_device *dev)
>  {
>  	unsigned int status;
>
> -	might_sleep();
> -
>  	if (virtio_check_mem_acc_cb(dev)) {
>  		if (!virtio_has_feature(dev, VIRTIO_F_VERSION_1)) {
>  			dev_warn(&dev->dev,
> --
> 2.27.0
>