linux-kernel - Re: [PATCH net 0/2] netpoll: Use RCU primitives for npinfo pointer access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzwLzfzjGgG28VYW@gondor.apana.org.au>
Date: Tue, 19 Nov 2024 11:53:49 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: patchwork-bot+netdevbpf@...nel.org
Cc: Breno Leitao <leitao@...ian.org>, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	horms@...nel.org, stephen@...workplumber.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	paulmck@...nel.org, Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH net 0/2] netpoll: Use RCU primitives for npinfo pointer
 access

On Tue, Nov 19, 2024 at 03:40:31AM +0000, patchwork-bot+netdevbpf@...nel.org wrote:
> Hello:
> 
> This series was applied to netdev/net.git (main)
> by Jakub Kicinski <kuba@...nel.org>:
> 
> On Mon, 18 Nov 2024 03:15:16 -0800 you wrote:
> > The net_device->npinfo pointer is marked with __rcu, indicating it requires
> > proper RCU access primitives:
> > 
> >   struct net_device {
> > 	...
> > 	struct netpoll_info __rcu *npinfo;
> > 	...
> >   };
> > 
> > [...]
> 
> Here is the summary with links:
>   - [net,1/2] netpoll: Use rcu_access_pointer() in __netpoll_setup
>     https://git.kernel.org/netdev/net/c/c69c5e10adb9
>   - [net,2/2] netpoll: Use rcu_access_pointer() in netpoll_poll_lock
>     https://git.kernel.org/netdev/net/c/a57d5a72f8de

These are not bug fixes.  They should not be going through during
a merge window, especially with such a short period of review.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt