linux-kernel - Re: [PATCH v2] scsi: ufs: core: Add ufshcd_send_bsg_uic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d269ee6-0b85-4f9f-93fb-08bd07b6195c@quicinc.com>
Date: Tue, 19 Nov 2024 14:11:13 +0800
From: Ziqi Chen <quic_ziqichen@...cinc.com>
To: Avri Altman <Avri.Altman@....com>,
        "quic_asutoshd@...cinc.com"
	<quic_asutoshd@...cinc.com>,
        "quic_cang@...cinc.com" <quic_cang@...cinc.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "mani@...nel.org"
	<mani@...nel.org>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "junwoo80.lee@...sung.com" <junwoo80.lee@...sung.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "quic_nguyenb@...cinc.com" <quic_nguyenb@...cinc.com>,
        "quic_nitirawa@...cinc.com" <quic_nitirawa@...cinc.com>,
        "quic_rampraka@...cinc.com" <quic_rampraka@...cinc.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        Alim Akhtar
	<alim.akhtar@...sung.com>,
        "James E.J. Bottomley"
	<James.Bottomley@...senPartnership.com>,
        Damien Le Moal <dlemoal@...nel.org>, Hannes Reinecke <hare@...e.de>,
        Peter Wang <peter.wang@...iatek.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Andrew Halaney
	<ahalaney@...hat.com>,
        Maramaina Naresh <quic_mnaresh@...cinc.com>,
        open list
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: core: Add ufshcd_send_bsg_uic_cmd() for UFS
 BSG



On 11/19/2024 2:02 PM, Avri Altman wrote:
>> User layer applications can send UIC GET/SET commands via the BSG
>> framework, and if the user layer application sends a UIC SET command to the
>> PA_PWRMODE attribute, a power mode change shall be initiated in UniPro
>> and two interrupts shall be triggered if the power mode is successfully
>> changed, i.e., UIC Command Completion interrupt and UIC Power Mode
>> interrupt.
>>
>> The current UFS BSG code calls ufshcd_send_uic_cmd() directly, with which
>> the second interrupt, i.e., UIC Power Mode interrupt, shall be treated as
>> unhandled interrupt. In addition, after the UIC command is completed, user
>> layer application has to poll UniPro and/or M-PHY state machine to confirm
>> the power mode change is finished.
>>
>> Add a new wrapper function ufshcd_send_bsg_uic_cmd() and call it from
>> ufs_bsg_request() so that if a UIC SET command is targeting the
>> PA_PWRMODE attribute it can be redirected to ufshcd_uic_pwr_ctrl().
>>
> 
> Fixes tag?
Thank Avri， will update new version to add Fixes tag.

>> Signed-off-by: Can Guo <quic_cang@...cinc.com>
>> Signed-off-by: Ziqi Chen <quic_ziqichen@...cinc.com>
> With that fixed:
> Reviewed-by: Avri Altman <avri.altman@....com>
> 
>> ---
>> V1 -> V2: Rebased on Linux 6.13