linux-kernel - Re: [PATCH v2] perf/test: fix perf ftrace test on s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zzvh1XZzxXrUdhG-@google.com>
Date: Mon, 18 Nov 2024 16:54:45 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Thomas Richter <tmricht@...ux.ibm.com>
Cc: linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
	acme@...nel.org, james.clark@...aro.org, agordeev@...ux.ibm.com,
	gor@...ux.ibm.com, sumanthk@...ux.ibm.com, hca@...ux.ibm.com,
	Sven Schnelle <svens@...ux.ibm.com>
Subject: Re: [PATCH v2] perf/test: fix perf ftrace test on s390

On Fri, Nov 15, 2024 at 07:57:35AM +0100, Thomas Richter wrote:
> On s390 the perf test case ftrace sometimes fails as follows:
> 
>   # ./perf test ftrace
>   79: perf ftrace tests    : FAILED!
>   #
> 
> The failure depends on the kernel .config file. Some configurarions
> always work fine, some do not.  The ftrace profile test mostly fails,
> because the ring buffer was not large enough, and some lines
> (especially the interesting ones with nanosleep in it) where dropped.
> 
> To achieve success for all our tested kernel configurations, enlarge
> the buffer to store the traces complete without wrapping.
> The default buffer size is too small  for all kernel configurations.
> Set the buffer size of /sys/kernel/tracing/buffer_size_kb to 16 MB
> 
> Output after:
>   # ./perf test ftrace
>   79: perf ftrace tests     : Ok
>   #
> 
> Signed-off-by: Thomas Richter <tmricht@...ux.ibm.com>
> Suggested-by: Sven Schnelle <svens@...ux.ibm.com>
> Reviewed-by: James Clark <james.clark@...aro.org>
> ---
>  tools/perf/tests/shell/ftrace.sh | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/tools/perf/tests/shell/ftrace.sh b/tools/perf/tests/shell/ftrace.sh
> index a6ee740f0d7e..6161a8bdc251 100755
> --- a/tools/perf/tests/shell/ftrace.sh
> +++ b/tools/perf/tests/shell/ftrace.sh
> @@ -14,6 +14,11 @@ output=$(mktemp /tmp/__perf_test.ftrace.XXXXXX)
>  
>  cleanup() {
>    rm -f "${output}"
> +  if [ "$(uname -m)" = "s390x" ]
> +  then
> +	echo $ftrace_size > /sys/kernel/tracing/buffer_size_kb
> +  fi
> +
>  
>    trap - EXIT TERM INT
>  }
> @@ -80,6 +85,12 @@ test_ftrace_profile() {
>      echo "perf ftrace profile test  [Success]"
>  }

Could you please use `perf ftrace profile -m 16M ...` instead?

Thanks,
Namhyung

>  
> +if [ "$(uname -m)" = "s390x" ]
> +then
> +	ftrace_size=$(cat /sys/kernel/tracing/buffer_size_kb)
> +	echo 16384 > /sys/kernel/tracing/buffer_size_kb
> +fi
> +
>  test_ftrace_list
>  test_ftrace_trace
>  test_ftrace_latency
> -- 
> 2.47.0
>