linux-kernel - Re: [PATCH 00/11] Wire up CRC-T10DIF library functions to arch-optimized code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXFA15AuT5wd0vMJ3X94uysvnGLy42FAQt8fxJsW31UdAg@mail.gmail.com>
Date: Tue, 19 Nov 2024 09:59:53 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-crypto@...r.kernel.org, 
	linuxppc-dev@...ts.ozlabs.org, x86@...nel.org, 
	Zhihang Shao <zhihang.shao.iscas@...il.com>
Subject: Re: [PATCH 00/11] Wire up CRC-T10DIF library functions to
 arch-optimized code

On Sun, 17 Nov 2024 at 01:23, Eric Biggers <ebiggers@...nel.org> wrote:
>
> This patchset is also available in git via:
>
>     git fetch https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git crc-t10dif-lib-v1
>
> This patchset updates the kernel's CRC-T10DIF library functions to be
> directly optimized for x86, arm, arm64, and powerpc without taking an
> unnecessary and inefficient detour through the crypto API.  It follows
> the same approach that I'm taking for CRC32 in the patchset
> https://lore.kernel.org/linux-crypto/20241103223154.136127-1-ebiggers@kernel.org
>
> This patchset also adds a CRC KUnit test suite that covers multiple CRC
> variants, and deletes some older ad-hoc tests that are obsoleted by it.
>
> This patchset has several dependencies including my CRC32 patchset and
> patches queued in several trees for 6.13.  It can be retrieved from git
> using the command given above.  This is targeting 6.14.
>
> Eric Biggers (11):
>   lib/crc-t10dif: stop wrapping the crypto API
>   lib/crc-t10dif: add support for arch overrides
>   crypto: crct10dif - expose arch-optimized lib function
>   x86/crc-t10dif: expose CRC-T10DIF function through lib
>   arm/crc-t10dif: expose CRC-T10DIF function through lib
>   arm64/crc-t10dif: expose CRC-T10DIF function through lib
>   powerpc/crc-t10dif: expose CRC-T10DIF function through lib
>   lib/crc_kunit.c: add KUnit test suite for CRC library functions
>   lib/crc32test: delete obsolete crc32test.c
>   powerpc/crc: delete obsolete crc-vpmsum_test.c
>   MAINTAINERS: add entry for CRC library
>

Nice work. The shash API glue was particularly nasty, so good riddance.

For the series,

Reviewed-by: Ard Biesheuvel <ardb@...nel.org>

Happy to take a R: or M: as well, if you need the help.