linux-kernel - RE: [PATCH] reset: rzg2l-usbphy-ctrl: Assign proper of node to the allocated device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB113469C850289353DD9C28F7C86202@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Tue, 19 Nov 2024 09:06:40 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Claudiu.Beznea <claudiu.beznea@...on.dev>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>, "broonie@...nel.org" <broonie@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jbrunet@...libre.com" <jbrunet@...libre.com>, Claudiu.Beznea
	<claudiu.beznea@...on.dev>, Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: RE: [PATCH] reset: rzg2l-usbphy-ctrl: Assign proper of node to the
 allocated device

Hi Claudiu,

Thanks for the patch.

> -----Original Message-----
> From: Claudiu <claudiu.beznea@...on.dev>
> Sent: 19 November 2024 08:56
> Subject: [PATCH] reset: rzg2l-usbphy-ctrl: Assign proper of node to the allocated device
> 
> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> 
> The platform device named "rzg2l-usb-vbus-regulator", allocated by the rzg2l-usbphy-ctrl driver, is
> used to instantiate a regulator driver.
> This regulator driver is associated with a device tree (DT) node, which is a child of the rzg2l-
> usbphy-ctrl DT node. The regulator's DT node allows consumer nodes to reference the regulator and
> configure the regulator as needed.
> 
> Starting with commit cd7a38c40b23 ("regulator: core: do not silently ignore provided init_data") the
> struct regulator_dev::dev::of_node is no longer populated using of_node_get(config->of_node) if the
> regulator does not provide init_data. Since the rzg2l-usb-vbus-regulator does not provide init_data,
> this behaviour causes the of_find_regulator_by_node() function to fails, resulting in errors when
> attempting to request the regulator.
> 
> To fix this issue, call device_set_of_node_from_dev() for the "rzg2l-usb-vbus-regulator" platform
> device.
> 
> Fixes: 84fbd6198766 ("regulator: Add Renesas RZ/G2L USB VBUS regulator driver")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>

Reviewed-by: Biju Das <biju.das.jz@...renesas.com>

Cheers,
Biju

> ---
>  drivers/reset/reset-rzg2l-usbphy-ctrl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/reset/reset-rzg2l-usbphy-ctrl.c b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> index 1cd157f4f03b..4e2ac1f0060c 100644
> --- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> +++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> @@ -176,6 +176,7 @@ static int rzg2l_usbphy_ctrl_probe(struct platform_device *pdev)
>  	vdev->dev.parent = dev;
>  	priv->vdev = vdev;
> 
> +	device_set_of_node_from_dev(&vdev->dev, dev);
>  	error = platform_device_add(vdev);
>  	if (error)
>  		goto err_device_put;
> --
> 2.39.2